Comments (6)
@olstenlarck maybe consider adding a configuration option to set required status checks?
Renovate does something similar prior to auto-accepting pull requests - https://renovateapp.com/docs/configuration-reference/configuration-options#requiredstatuschecks
from app.
I believe changing it to
statuses.data.forEach((x) => {
const isCIStatus = /(?:travis-ci|circleci)/.test(x.context)
const isPending = x.state === 'pending'
const isPassing = x.state === 'success'
if (isPending && isCIStatus && !cache.pending.includes(x.context)) {
cache.pending.push(x.context)
}
if (isPassing && isCIStatus && !cache.passed.includes(x.context)) {
cache.passed.push(x.context)
}
})
would be enough
from app.
@olstenlarck I think you would only want to release after status all pass.
In the case of bitHound
, if someone submitted a pull request, and the bitHound
status came back as failed, I would not accept the pull request, because it failed a requirement. (If bitHound
is not required then why have it?)
So, if a status is required (it can fail) then a release should wait on it.
from app.
Yea, but i'm not sure if status object from the api has such thing as "isRequired". Also it's a good thing to do all that in CI. Just add jobs that calls tests and other similiar checks as bitHound on the CI, so we can only check of CI passes. Makes things a lot easier.
Personally i like it that way. Also bitHound and such services may take very long time. Time that i don't have while constantly developing and updating and releasing new versions of my packages. Actually packages that builds that whole thing - detect-new-version, parse-commit-message, new-release, execa-pro and etc.
Once all is much stable, we can switch to check all statuses or add option for that through configuration file.
from app.
Yup, it's in the roadmap.
from app.
Also... the bitHound - Code
status check returns fail status for even easy things like TODO
comment.. which is ridiculous to me. Of course i will have them temporary, but.. until then i'm not allowed to release new versions? Damn shit :D So yea, configurable status checks that not includes it by default.
the lint issue is actually intentional eslint warning, for console.log
statement.
from app.
Related Issues (20)
- Add commit body & footer after the bullets list HOT 1
- template: the `commit.heading` is empty when (v1.0.0 / first) major release is published HOT 1
- Add config option for required status checks
- Reminder to not forget what is the trick with now.sh
- Support release template to link updated dependencies
- Don't rely on `context.github.repos.getTags` but on `new-release`'s `getVersions` HOT 1
- Use `new-release@4`
- Activate Renovate and add CircleCI job for auto releasing to Now.sh
- Publishes releases before CI ends HOT 1
- Release template
- Detect `[skip ci]` and `[ci skip]` insensitive
- For the config: allow a list of regexes for "required" status checks
- Reimplement from scratch - done (in ~100 lines as a whole) HOT 2
- Monorepo support HOT 5
- Bug in rendering HOT 3
- remove npmRegistry config HOT 5
- Use `pkg.version` instead of `pkg.dist-tags.latest`? HOT 1
- Don't use NPM et al HOT 1
- Catch if getTags throws and fallback HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from app.