StarGeometry compilation fail

[star-bnl]

StarGeometry compilation fail

[klendathu2k]

Suspect that cons lacks a rule to update XML --> .cxx when the parser changes.
Try

rm .sl73_gcc485/OBJ/StarVMC/StarGeometry/*

and rebuild.

[genevb]

Nope. I tried that and got both the same error as last night, and the files you had me remove were not re-built (that directory [both obj and OBJ] is now empty after the attempted build).

…

-Gene

[genevb]

Actually, it wasn't exactly the same error this time. Instead of "AddCut", it's complaining about "AddHit" over and over now.... /afs/rhic.bnl.gov/star/packages/gitdev/.sl73_gcc485/obj/StarVMC/StarGeometry/EiddGeo.cxx: In member function 'virtual void EIDDGEO::TGAP::Block(AgCreate)': /afs/rhic.bnl.gov/star/packages/gitdev/.sl73_gcc485/obj/StarVMC/StarGeometry/EiddGeo.cxx:792:33: error: 'class AgModule' has no member named 'AddHit' module()->AddHit( "TGAP", "z", 0.0005, 0, 0, "s"); ^ /afs/rhic.bnl.gov/star/packages/gitdev/.sl73_gcc485/obj/StarVMC/StarGeometry/EiddGeo.cxx:793:33: error: 'class AgModule' has no member named 'AddHit' module()->AddHit( "TGAP", "y", 0.0005, 0, 0, ""); ^ ...

[klendathu2k]

I can reproduce this in a local build. There is something odd going on here... investigating.

…

On 2021-12-17 10:44, Gene Van Buren wrote: Nope. I tried that and got both the same error as last night, and the files you had me remove were not re-built (that directory [both obj and OBJ] is now empty after the attempted build). -Gene -- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. Triage notifications on the go with GitHub Mobile for iOS [3] or Android [4]. You are receiving this because you commented.Message ID: ***@***.***> Links: ------ [1] #258 (comment) [2] https://github.com/notifications/unsubscribe-auth/ANL4LVBNPLLFVIBAYMW7G7LURNLGPANCNFSM5KH6INNQ [3] https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!VA87UXN3P4jANLxPCYFM80jjYOyDAx2ClTZQ7DoRtnFPauxhdpsb1voLUwpQqy4$ [4] https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!VA87UXN3P4jANLxPCYFM80jjYOyDAx2ClTZQ7DoRtnFPauxhdpsb1voLboRDSn4$

[klendathu2k]

I think that cons is getting confused, and mixing in the .h and .cxx files from $STAR, instead of building them from the XML files. The following works -- setup 32b starver dev setenv STAR . cons +StarVMC/Geometry cons +StarVMC/StarGeometry cons +StarVMC/xgeometry Jason

…

On 2021-12-17 11:46, jwebb wrote: I can reproduce this in a local build. There is something odd going on here... investigating. On 2021-12-17 10:44, Gene Van Buren wrote: > Nope. I tried that and got both the same error as last night, and the > files you had me remove were not re-built (that directory [both obj > and OBJ] is now empty after the attempted build). > > -Gene > > -- > Reply to this email directly, view it on GitHub [1], or unsubscribe > [2]. > Triage notifications on the go with GitHub Mobile for iOS [3] or > Android [4]. > You are receiving this because you commented.Message ID: > ***@***.***> > > Links: > ------ > [1] > #258 (comment) > [2] > https://github.com/notifications/unsubscribe-auth/ANL4LVBNPLLFVIBAYMW7G7LURNLGPANCNFSM5KH6INNQ > [3] > https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!VA87UXN3P4jANLxPCYFM80jjYOyDAx2ClTZQ7DoRtnFPauxhdpsb1voLUwpQqy4$ > [4] > https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!VA87UXN3P4jANLxPCYFM80jjYOyDAx2ClTZQ7DoRtnFPauxhdpsb1voLboRDSn4$

[genevb]

AutoBuild succeeded with these instructions. Thanks, Jason. Should this issue remain open until this issue is resolved in cons for the next time, or should we close the issue? I have no preference.

…

-Gene

On Dec 17, 2021, at 12:15 PM, klendathu2k ***@***.***> wrote: I think that cons is getting confused, and mixing in the .h and .cxx files from $STAR, instead of building them from the XML files. The following works -- setup 32b starver dev setenv STAR . cons +StarVMC/Geometry cons +StarVMC/StarGeometry cons +StarVMC/xgeometry Jason

[klendathu2k]

I say keep it open until the next successful autobuild.

…

On 2021-12-17 15:02, Gene Van Buren wrote: AutoBuild succeeded with these instructions. Thanks, Jason. Should this issue remain open until this issue is resolved in cons for the next time, or should we close the issue? I have no preference. -Gene > On Dec 17, 2021, at 12:15 PM, klendathu2k ***@***.***> wrote: > I think that cons is getting confused, and mixing in the .h and .cxx > files from $STAR, instead of > building them from the XML files. > > > The following works -- > > setup 32b > starver dev > setenv STAR . > cons +StarVMC/Geometry > cons +StarVMC/StarGeometry > cons +StarVMC/xgeometry > > Jason -- Reply to this email directly, view it on GitHub [1], or unsubscribe [2]. Triage notifications on the go with GitHub Mobile for iOS [3] or Android [4]. You are receiving this because you commented.Message ID: ***@***.***> Links: ------ [1] #258 (comment) [2] https://github.com/notifications/unsubscribe-auth/ANL4LVHIA7A6FVR7YJ4BTDDUROJMZANCNFSM5KH6INNQ [3] https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!SFjxNzHxuAXPquRc1Y3SIKqLimhFoIwpUu7jD7pcan8tnLZV1ORIfJFQGd7BL6M$ [4] https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!SFjxNzHxuAXPquRc1Y3SIKqLimhFoIwpUu7jD7pcan8tnLZV1ORIfJFQYho7Q9M$

[plexoos]

@veprbl proposed a patch (#261) that is likely to fix this issue. In the original PR #202 Jason modified mgr/Dyson/Export/AgROOT.py, a script that generates c++ code from the xml files. In this case, Cons was supposed to regenerate the c++ code just like when the xml files are modified but such dependency was not established directly. This fix creates the missing dependency on the parser scripts.

We don't see this kind of problems in CI builds because the entire code is built from scratch every time in an empty .sl##_gcc### directory. The errors from AutoBuild suggest that the build was likely performed with an existing .sl##_gcc### directory and not all sources were properly regenerated.

I don't expect any side effects from #261 and suggest we accept it

[genevb]

Yes: AutoBuild has always been an incremental build, not a build from scratch.

…

-Gene On Dec 18, 2021, at 12:02 PM, Dmitri Smirnov ***@***.******@***.***>> wrote: We don't see this kind of problems in CI builds because the entire code is built from scratch every time in an empty .sl##_gcc### directory. The errors from AutoBuild suggest that the build was likely performed with an existing .sl##_gcc### directory and not all sources were properly regenerated.

[plexoos]

It shouldn't matter for a properly configured build system. Similarly, the value of $STAR should not affect the build of the entire source code checked out locally. This issue seems to expose an oversight in Cons which may be fixed with the patch.