Problem with flexible array members in OnlTools unions

[star-bnl]

Problem with flexible array members in OnlTools unions

[plexoos]

A fix like this seems to silence the compiler:

-TH1 *array[];
+TH1 *array[1];

56aa19a

@jml985 Do you have a better solution?

[jml985]

I'll check later this afternoon.

[jml985]

@plexoos I put in a pull request #369 updating all of the builders according to your suggestion. This works fine with the use.

[plexoos]

Thank you Jeff for looking into this. I think in your last commit on jml985:JevpProduction you missed a few builders. If you look at my commit 56aa19a there are a few builders which use a different name for the array of histogram pointers, e.g. TH2 *tbVsAdcArray[]; instead of TH1 *array[]; as in my example above. I don't think I missed anything because the code actually compiles with gcc 11 and the errors are not reported anymore. In the log message I documented the command I came up with to do the substitution, it can be used to recreate the patch.

[jml985]

Ok. Do I need to update my pull request or does your patch go directly into it? I see that the pull request CI seems to still have an error.