Generated patch contains array `length`

[starcounter-jack]

Generated patch contains array `length`

[psmolenski]

I have prepared a sample test case:

it('should generate the same patch using Object.observe and shim', function() {
      var arr1 = [
        ["Albert", "Einstein"],
        ["Erwin", "Shrodinger"]
      ];
      var arr2 = arr1.slice();
      var newRecord = ['Niels', 'Bohr'];
      var observer1 = jsonpatch.observe(arr1);
      arr1.push(newRecord);
      var objectObservePatches = jsonpatch.generate(observer1);
      var _observe = Object.observe;
      Object.observe = undefined;
      var observer2 = jsonpatch.observe(arr2);
      arr2.push(newRecord);
      var shimPatches = jsonpatch.generate(observer2);
//fails because objectObservePathes has an extra patch with "length" property
      expect(objectObservePatches).toEqual(shimPatches); 
      Object.observe = _observe;
    });

[warpech]

After studying http://tools.ietf.org/html/rfc6902 and some sample test cases here https://github.com/mikemccabe/json-patch-tests I think the only good solution is to NOT include length in the produced patch. I will submit a fix

[warpech]

Thanks @psmolenski, I added your test to the test suite

[warpech]

This issue is fixed in v0.3.3

[tomalec]

It seems that such behavior is not a bug in Chrome, but desired behavior for Object.observe it's even mentioned in spec.

That's the main difference with Array.observe, which I believe we should use for array(-like) nodes.

[tomalec]

I'll clean our .length logic at 0552ac6. So users may use 'length' property name for non-array objects. For arrays, we will handle splice change type.