Comments (4)
I did a little investigation into various deep copy methods, as I'm sure you have as well, and my conclusion was that the more important it is for the copy to be "correct" the greater the overhead involved to implement it. For example here's a pretty involved algorithm to do deep copy:
http://oranlooney.com/static/javascript/deepCopy.js
...that is described here:
http://oranlooney.com/deep-copy-javascript/
I didn't run any tests, but just looking at it I'm sure it will slow the generator down substantially, which kind of defeats the main stated benefit of this project over others. For my project I just implemented a simple work around that converts all dates to JSON strings before the object ever gets to the observer/generator:
https://github.com/xtuple/xtuple/blob/master/lib/backbone-x/source/model.js#L331
https://github.com/xtuple/xtuple/blob/master/lib/backbone-x/source/model_mixin.js#L238
If I stumble upon a better idea I will circle back on this.
Best,
John
from json-patch.
I tried to fix it in the shimmed version, but I abandoned it because it won't run in the native (Object.observe) version anyway.
Reason: Object.observe can't detect changes in the Date object (tested in Chrome 28 and Chrome 30 Canary) - http://jsfiddle.net/ytz93/
from json-patch.
As Date is not a value type and as we want to be compatible with Ecmascript Next Object.observe, I'm now closing this. I'll reopen the issue if anyone can provide some compelling new insight on the subject.
from json-patch.
So, how do we generate patches for dates?
Maybe that custom comparison function could help: #92
from json-patch.
Related Issues (20)
- rrrr HOT 1
- Add performance comparison with jsondiffpatch
- Array patching, over empty elements.. HOT 2
- Any plans for a new release? HOT 1
- Maybe it's already discussed, but anyone think of how to patch array member in a more flexible approach?
- Release 3.1.1 request based on PR merged of #262 HOT 2
- Inaccurate documentation HOT 1
- Error index always 0? HOT 1
- Optional observe callback not called HOT 1
- applyPatch() validator index is not incrementing
- Backport fix for GHSA-8gh8-hqwg-xf34 to v2 HOT 5
- package.json should use `conditional exports`, else esm won't work inexplicitly HOT 1
- Node12+ import documentation incorrect
- Documentation for `generate` mentions wrong signature
- auto add tests to "add/remove" operations like for "replace"
- Mixing default exports and named exports breaks parcel HOT 2
- Attempting to use if mirror has a toJSON and object does not breaks HOT 2
- applying a replace patch is inconsistent with path="" and path="/"
- Is the project dead ? HOT 1
- 3.1.1 commonjs delivery corrupted on npm HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-patch.