Comments (8)
Hello @idietmoran! Is this issue up for grabs?
from display-lock.
It is. I'm thinking the hotkey should be unregistered when a user navigates to the settings page, and reregistered when the user navigates away.
Make sure you do it on the develop branch.
Line 370-374 is where the switching is detected.
Thanks!
from display-lock.
@idietmoran I was wondering if I could potentially get some more clarification on the hotkey. I'm a little confused on what the hotkey is. Are you referring to the Settings options such as "Minimize on start", "Bring window to foreground", etc.?
from display-lock.
Currently this feature is only enabled on the develop branch.
There should be a small box at the bottom of the window that you can click into and set a hotkey.
Currently any registered hotkey will still activate while on this window.
Check hotkey.c in dispLib for more information.
The hotkey information is stored in a struct HOTKEY which is also in a struct SETTINGS.
Check common.h for struct implementations.
from display-lock.
Awesome. Thanks! That clarifies a lot. I didn't see the develop branch and was on the master branch when I opened up the project in VS.
from display-lock.
Yep, all work should be done on develop, or a branch checked out from develop.
Any tests you may want to add would be appreciated as well (although a lot of this stuff is hard to test against)
from display-lock.
Unfortunately this is going to have to wait for #42 which was just reopened. I'm not sure if you're still working on this, but someone found a bug with the method we used.
from display-lock.
No problem @idietmoran . I was still in the process of getting acquainted with the codebase as it's my first time working with a WinAPI application so not much was changed on my end yet. Thanks for the heads up!
from display-lock.
Related Issues (20)
- Factor out message loop
- Move from appveyor to github actions
- Add a setting to check for an update on startup
- Create installer HOT 1
- Create application whitelist
- Thank you. HOT 4
- Add setting to automatically run on startup
- Is there a way to have the cursor auto lock in a particular game without having to do anything? HOT 20
- System tray icon is not getting cleaned up on close
- Fix CI/CD for cmake
- Move from cmake_conan to conanfile
- [Feature Request] Toggle Display Lock option in context menu. HOT 7
- [Feature Request] Hold the left CTRL + Shift buttons while dragging cursor to let the cursor escape the game window. HOT 1
- Bring selected window to front when using task bar context menu. HOT 1
- Minimize to System Tray on Close Setting
- Start Button does not lock combobox HOT 1
- Assert Testing for Debug Builds
- Appveyor Script to get release info
- UI will not revert when application is closed
- Detect when a window style has changed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from display-lock.