Compilation issue on PowerPC64 with gcc 11 or 12 (?) on Ubuntu Jammy [false positive]

[stefanberger]

Compilation issue on PowerPC64 with gcc 11 or 12 (?) on Ubuntu Jammy [false positive]

[stefanberger]

Instrumentation of the code and displaying the offsets into the buffer and pointers shows that this is indeed a false positive.

diff --git a/src/tpm2/AlgorithmTests.c b/src/tpm2/AlgorithmTests.c
index 08ee6b02..479ad5c0 100644
--- a/src/tpm2/AlgorithmTests.c
+++ b/src/tpm2/AlgorithmTests.c
@@ -196,8 +196,10 @@ MakeIv(
        }
     else
        {
-           for(i = 0; i < size; i++)
+           for(i = 0; i < size; i++) {
+               fprintf(stderr, "iv: %p, i: %d\n", iv, i);
                *iv++ = i;
+           }
        }
     return size;
 }
@@ -220,6 +222,7 @@ TestSymmetricAlgorithm(

     //
     // Get the appropriate IV
+    fprintf(stderr,"==> buffer: %p\n", &iv.t.buffer[0]);
     iv.t.size = (UINT16)MakeIv(mode, test->ivSize, iv.t.buffer);
     // Encrypt known data
     CryptSymmetricEncrypt(encrypted, test->alg, test->keyBits, test->key, &iv,

[stefanberger]

For the record. This patch here resolves this issue [I will not apply it upstream]:

Do not inline MakeIV due toppc64 compiler issue

The ppc64 gcc compiler has an issue with MakeIv.

---
 src/tpm2/AlgorithmTests.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/src/tpm2/AlgorithmTests.c
+++ b/src/tpm2/AlgorithmTests.c
@@ -179,6 +179,9 @@
 /* 10.2.1.4.1 MakeIv() */
 /* Internal function to make the appropriate IV depending on the mode. */
 static UINT32
+#if defined(__powerpc64__)
+__attribute__((noinline))
+#endif
 MakeIv(
        TPM_ALG_ID    mode,     // IN: symmetric mode
        UINT32        size,     // IN: block size of the algorithm