Errorhandling

[stefanrinderle]

Errorhandling

[stefanrinderle]

Currently, i do not see any exceptions in the view. What is part of this review?

[stefanrinderle]

TODOs:

• If an error occurs during the initial loading phase (load metrics) show error with app status component and give retry solutioon
• If an error occurs during scene layout or loading show error and give settings as retry solution

[yvo-niedrich]

I have moved the WebGLDetection into the app-component, so that WebGL is checked in the initial load process. Can we show the error popup here as well?

The method in question is assertRequirementsAreMet in src/app.tsx.

[stefanrinderle]

Error processing and loading done.

• loading refactored. Loading implemented for
  • SonarQube metric service
  • SonarQube visualization service
  • Layout processing
  • Visualization processing
• Error handling defined for
  • WebGL detector
  • SonarQube metric service
  • SonarQube visualization service

[yvo-niedrich]

I'll do some tests in the browser tomorrow, but when running the unit tests i get a few warnings:

• SceneReactions
  
  (node:9799) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'statusText' of undefined
• <LoadingQueue/>
  
  [mobx.array] Attempt to read an array index (0) that is out of bounds (0). Please check length first. Out of bound indices will not be tracked by MobX

[stefanrinderle]

The error in the LoadingQueue is because i have to return something in StatusActionQueue.ts on line 45. The example implementations i used did not return a value on done = true because this will not be used anywhere. If i switch to null, everything can be null and this would blow up the code. So i didn't know how to fix that. If you have an idea for this, it would be great.

The error in Scenereactions.spec.ts should be gone now. I mixed up spies and mocks. Now using mocks and no more error messages.

[yvo-niedrich]

Initial Fix

5ddb2f9 fixes the warning. By casting the object a few times, we can fool TypeScript and don't have to access the (possibly) empty array.

return {
    done: true,
    value: undefined
} as any as IteratorResult<T>;

---

Ultimate Fix

By exposing the iterable interface of the array we don't have to implement the logic ourselfs. Also the return type has been changed from IterableIterator<StatusAction> to IterableIterator<T>, which was actually intended.

public [Symbol.iterator](): IterableIterator<T> {
    return this._queue[Symbol.iterator]();
}

See 474aba5 and 51ed724

[stefanrinderle]

Great, thanks for looking into it.

[yvo-niedrich]

Sorry for being so hard on this one. I'm not even certain which criteria were set for this issue / feature. If the problem is to be expected and as such accepted, we can skip it.

When invalidating the JSON from getVisualisation no scene is rendered and no error message displayed. Instead i get a few errors in console.error:

Other than that everything works like a charm. The Message + Reload button really useful (for the circumstances).

[stefanrinderle]

No worries. I would like to skip this because it's not reproducable without forcing something to break.

But we should keep the error processing in mind at the time we change to the official SQ API for all calls.

[yvo-niedrich]

All right, common errors are processed as expected. Then I'm closing this one.