Comments (4)
Had more issues during the implementation as expected beceause react does only catch the key events on "input"-like fields. Added comments in the code for details and to prevent further work on this.
I also think that the "r" key is enough and that we do not need a button in the view for that. Therefore, ready for review :-)
from softvis3d.
Some more work to do - see closed pull request #88
The keydown event is registered to the window: We cannot in good conscience add an Input field, because the event will still trigger anytime I type a "R"...
This also effects other SonarQube fields (eg. search).
from softvis3d.
What do you think of this? The legend is only visible, when the scene is the active element (and it is not toggled away).
We still listen to all the keydown elements on document
, but we only act on them when the Scene is active.
I've got the code functional, but I have to clean up a little bit and fix the tests (most likely).
from softvis3d.
I like it and would use this approach.
The only think is that I'm not sure if the buttons will disturb heavy users because they know which button to press. But would wait for anyone to complain about it before changing it. One possible solution would then be to use a browser cookie or something equivalent to save the "toggle legend" state over sessions.
from softvis3d.
Related Issues (20)
- We need a DIC HOT 6
- Remove getVisualization webservice and replace with frontend implementation HOT 4
- New scm metric number of commits HOT 1
- Format Date of Last Commit HOT 2
- Format Date of Last Commit HOT 1
- illustrator.draw(version) blocks UI thread HOT 4
- Refactor LoadAction / StatusQueue implementation
- Road Trimming HOT 1
- React component is not closed or destroyed if the plugin is not longer visible
- Project structure error since SQ 6.4 HOT 1
- Dark theme for all UI elements HOT 1
- Dark theme for packages and buildings in visualization
- Fix SonarQube 7.6 api changes
- Placeholder logo is no displayed
- More color choices for the color of the buildings HOT 9
- switch through default viewports
- Problem with sonarqube 8.8 HOT 4
- Advanced options tab shows hidden metrics HOT 1
- plugin fails on Sonarqube 10.3 HOT 3
- Reset camera position issues after reset camera HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from softvis3d.