Can we replace *testing T with an interface?

[steinfletcher]

Can we replace *testing T with an interface?

[anthonyfong100]

okay @steinfletcher that sounds wonderful i will go ahead with writing the PR then

[steinfletcher]

Hi @anthonyfong100. This sounds very useful. Would be happy to take a PR for this. Changes would need to be backwards compatible. For info, apitest uses testify under the hood. You can already override the Verifier to implement a custom assertions instead of using testify - see the Verifier interface in assert.go. I am planning to remove testify in a future commit, but it's really an implementation detail that the consumer shouldn't care about.

Cheers

[anthonyfong100]

Hey @steinfletcher i was thinking more along the lines of passing in an interface to replace the *testing.T and continue using testify to do the assertions. As of now, testify already supports accepting an interface testingT as its argument in place of the concrete class *testing.T. This solution is likely to be better as it allows us to leverage on numerous other assertion methods defined in testify. Do let me know your thoughts on this

[steinfletcher]

Hello @anthonyfong100. Sorry I wasn't clear. I also agree that there should be an interface TestingT. I was just adding some info on the existing design around assertions, which is completely compatible with the approach you suggest. You'll need to update the Verifier interface to use TestingT. Other than that I think it's a simple change.

I'll be removing testify in a future commit for a like-for-like solution, but that doesn't really affect your changes :)

[steinfletcher]

Looks great @anthonyfong100. Many thanks!