Comments (8)
I've made this PR now to the workshop to comment out the push to dockerhub so that workshop docker image is never overwritten stemangiola/bioc_2020_tidytranscriptomics#41
Then I could update the README and website to use 1.1.5
Could you make a release of tidybulk 1.1.5?
so that if I add this it works install_github("stemangiola/[email protected]")
from tidybulk.
Done https://github.com/stemangiola/tidybulk/releases/tag/v1.1.5
from tidybulk.
hmm I don't have a strong preference but maybe identify_abundant?
but will this be consistent with scale_abundance and test_differential_abundance which output the lowly_abundant column with TRUE for low abundant and FALSE if not low abundant? as is your new function going to do the opposite - add TRUE if abundant & FALSE if not abundant? If so do you think that might be confusing and would adding in lowly be better e.g. identify_lowly_abundant?
from tidybulk.
The big picture:
I am making data filtering an external process (and warn if some processes usually need it but it has not been performed), so it is more clear what each function does, as they should do one thing only when possible (as we already discussed)
The introduction of a function that labels abundant genes:
I though in this case that a positive statement is better than a negation. In the same sense we keep abundant. So the new column produced will be .abundant
TRUE/FALSE. (same think will happen with variable genes)
I know this breaks compatibility and should never be done, but the package is in a maturing phase, and sometimes some redesign is beneficial.
What do you think?
from tidybulk.
Ok cool, makes sense.
Here's my order of preference by what those function names suggest to me (feel free to disagree 😄 )
identify_abundant - is abundant true/false (that's the clearest to me for what it's going to do)
label_abundant - label seems like it's going to add a label that's more than just true/false?
mark_abundant - mark seems like it's going to add a mark that's more than just true/false?
flag_abundant - flag =bit jargony?
annotate_abundant - annotate sounds like it's going to add more info than just true/false?
find_abundant - "find is to encounter or discover by accident; to happen upon while identify is to establish the identity of someone or something" so find is not quite right?
One other thought, if changes like these break compatibility do you think there should/could be a tidybulk release made that remains stable for the bioc2020 workshop? the docker image will be stable but should we also pin a specific version of tidybulk so that the install from github works in a reproducible way?
from tidybulk.
Cool I like identify_abundant too.
For the workshop, does not the docker image contain all the software with the right version? Another approach would be to point the dependency to the right github version, since R does not store all versions.
from tidybulk.
For the workshop, does not the docker image contain all the software with the right version? Another approach would be to point the dependency to the right github version, since R does not store all versions.
Yes the docker image should be fine, I was thinking of the alternative install from github method we put in the instructions. To point to right github version do you mean this?
install_github("stemangiola/[email protected]")
That is what I was thinking of i.e. changing the install instructions to specify the 1.1.5 version (tidybulk would need to add a 1.1.5 release tag I think?), assuming the breaking changes will be in >1.1.5.
from tidybulk.
That's exact. We should make clear that the right version is 1.1.5.
THERE COULD BE A TRAP THOUGH. If we update the README of Vignette, the docker image will be updated as well. For reproducibility purposes we should deactivate any automatic build of the docker image. Since the workshop has finished, that should never be changed again.
So while I don't think the vignette could change, we could put a note on the README.
Coulple of notes:
- thats workshop will go as part of our workshop series on tidytranscriptomics, so people in the future will use that more I think
- the right way to update tidybulk should be in theory to create perameter deprecation and keep life the old framework for a while. So if the user uses the old parameter will be warned and the old framework will be used. In this case though, the framework is quite huge and duplicating all that code is not a joke, and I don't have the bandwidth to do all this now. So we have to do a small sacrifice in reproducibility.
Let me know what you think about the docker business, you might have a better idea of me on that.
from tidybulk.
Related Issues (20)
- for SE save internals within the metadata rather than attributes.
- github action mac fail HOT 1
- DEG Analysis Between Single Group with Multiple Groups HOT 6
- "Proportion of variance explained" values on reduce_dimensions() output HOT 1
- github actions give preflight error for the whole tidy stack HOT 1
- ERROR; return code from pthread_create() is 22 HOT 3
- pathway analysis using tidybulk HOT 8
- Design and contrasts for tidybulk test differential abundance function HOT 9
- Remove batch effect in test_differential_abundance
- Warning in CHECK, mistery
- test
- Improve the documentation for `tidybulk` HOT 29
- turn pseudobulk from scRNAseq with logCPM value back to a seurat object with counts value? HOT 2
- `tidybulk` Remove hard dependency for `DESeq2` HOT 12
- in `test_gene_rank` check if any feature is NA, because pivot_feature will fail
- the attribute "internals" $ tt_columns abundance_scaled, carries the environment with it inflating the RDS file size
- Prepare for upcoming Seurat v5 release
- Add the method to simplify complete confounders is they are not factor of interest
- limma:MakeContrasts integration issues HOT 2
- The sample data of the `test_gene_enrichment()` function reports an error and cannot be used. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidybulk.