Giter Site home page Giter Site logo

Comments (8)

stephenberry avatar stephenberry commented on June 17, 2024

Thanks for pointing out this bug. Will work on fixing it.

from glaze.

arturbac avatar arturbac commented on June 17, 2024

The problem is in logic here
Instead of verification and expecting end of line You are testing for end of line and if that not happens row is not incremented and another set of keys is read from completely wrong position
for csv those conditionals maybe should be changed to expectations and report failure ..
obraz

from glaze.

arturbac avatar arturbac commented on June 17, 2024

Yep this fixes code and tests for me maybe not efficient but correct
obraz

from glaze.

arturbac avatar arturbac commented on June 17, 2024

This would be more efficient.
obraz

from glaze.

arturbac avatar arturbac commented on June 17, 2024

PR or You want to fix it Yourself ?

from glaze.

stephenberry avatar stephenberry commented on June 17, 2024

It will probably be fixed faster if you're able to issue a PR

from glaze.

arturbac avatar arturbac commented on June 17, 2024

ok, I will work on it.

from glaze.

stephenberry avatar stephenberry commented on June 17, 2024

Fixed in #771

from glaze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.