unexpected changes in `camelToSnake()` at v1.176.1

[mishio-n]

unexpected changes in `camelToSnake()` at v1.176.1

[stephenh]

I believe #1052 is a good approach, and at least fixes all current test cases 😅 , I went ahead and merged the fix, let us know if there are other exceptions. 🤞

[daeteck]

Same problema here. This is a breaking change that is given us a lot of problems.

[stephenh]

Hey guys, thanks for the report! Hopefully it won't be too bad to craft a regex that achieves both goals--I'll take a look at this in a few days/next weekend, unless @BrandonArmand you can take a look/beat me to it. Thanks!

[BrandonArmand]

Hey yeah i actually noticed this today as well. I will be happy to whip up some regex.

[mishio-n]

Thanks.

I think, the original cause was two-fold:

1. the consecutive capital letters were not being treated as independent words.
2. metacharacter \w contains capital letters.

For 1.
Consider a series of uppercase letters as a word, and consider that they can be separated by one before they change to lowercase letters.

For 2.
Use [a-z0-9] insted of \w.

So, I came up with the following regular expression.

export function camelToSnake(s: string): string {
  return s.replace(/(?<!^)([a-z0-9][A-Z]|([A-Z][A-Z])[a-z0-9])/g, (m) => m.length === 2 ? m[0] + "_" + m[1] :  m[0] + "_" + m[1] + m[2]).toUpperCase();
}

// getAPIValueV1Beta1 => GET_API_VALUE_V1_BETA1

I have passed the test case, but I feel it is not very elegant.

If you have any good ideas, please let me know.

[stephenh]

🎉 This issue has been resolved in version 1.176.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release
• v1.176.2

Your semantic-release bot 📦🚀

[mishio-n]

@stephenh Thank you so much for the fix !