Angular: Build error "Cannot find name 'Buffer'" when using a bytes field.

[stephenh]

Angular: Build error "Cannot find name 'Buffer'" when using a bytes field.

[stephenh]

@timostamm hm, does Buffer.from actually work in a browser? I get the declare class Buffer makes the TS compiler happy, but if that line is actually invoked, does it work? Do some of the browsers have Buffer.from implemented?

I think I mentioned it else where, but I'd love to have an integration/angular directory with a super-simple version of your setup that shows an angular app using ts-proto output.

Could we start with that? I.e. a PR for the "toy angular app that uses ts-proto"?

[timostamm]

@stephenh, nodes' Buffer is built on top of the ECMA Uint8Array and not available in any browser.

A simple angular setup should not be a problem. A test suite with node and browser coverage on generated code on the other hand is not trivial at all. Let's start simple. I should be able to find some time in the coming week to setup a basic angular example.

[stephenh]

not available in any browser

Okay, that makes sense. That's why I was thinking that the proposed fix of declare class Buffer is not really sufficient, because it will make the compile error go away (by making TS think there is a Buffer class), but if the generated code ever calls that method, it won't actually work...

Like we probably need to change the generated code to realize "Buffer is not available" and use something else instead.

in the coming week to setup a basic angular example

Sounds great.

[yiochen]

Can we include buffer when generating for browser.

[stephenh]

I'm pretty sure this is fixed in v1.48.0. Basically prefixing Buffer with globalThis.Buffer. Let me know if not.