Practise TDD please.

[steida]

Practise TDD please.

[stephenlacy]

You do know that I need to get the tests to pass Travis. It is a pain to enable git to function on travis, thus the removal of several tests such as push.
Common, be respectable with other projects.

Thank you.

[steida]

Sorry, I was angry. Thank you for your work.

[stephenlacy]

It's alright, thanks for telling me about the issues.

[steida]

Take a look at https://github.com/steida/este how Travis is enabled on git project. It's easy. Just enable per project here: https://travis-ci.org/profile, add travis file, point npm test to gulp or mocha. Done.

[stephenlacy]

Yes, I have it enabled. What I was mentioning was git runs very slow on a travis box. Usually longer than a usual 2000ms mocha timeout. In order to test the git push I would need to add a git user and credentials.
As you can see I have mocha tests, only for the ones which do not require a git user: https://github.com/stevelacy/gulp-git/blob/master/test/main.js

[steida]

I think I can help you. The reason why we prefer unit tests over integration tests (they are still great, but should be written after unit tests) is: Mockup boundaries.

You should not test git itself. It works, and we all know it. Instead, mock how you call it. Probably exec. How to do it? Add optional parameter into constructor or method (it is called poor man DI).

doSomethingWithGit = function(someParams, opt_exec) {
exec = exec || opt_exec;
}

With such aproach, you can mock exec/git cmd behaviour. As result, tests will be super fast and easy to write.

Hope this helps.

[steida]

You need integration tests only when you are going across boundaries. http://blog.8thlight.com/uncle-bob/2014/04/30/When-tdd-does-not-work.html

[steida]

Feel free to ask if something is not obvious.

[xixixao]

@steida You don't need mocking to test that behavior (2nd error). That said, the error would most likely not occur if the source was in idomatic CoffeeScript instead of JS:

    exec cmd, cwd: cwd, (err, stdout, stderr) =>
      cb err if err
      gutil.log stdout, stderr
      @push file for file in files
      cb()

Nice example.