Comments (8)
Why would the flush function not get called?
Does the console show the git command getting executed?
from gulp-git.
Here's sample code.
Environment setup.
git clone https://github.com/stevelacy/gulp-git.git
cd gulp-git
echo "test" > new_file.txt
git add . -A
git commit -m "Added new file"
npm install
gulp-git/gulpfile.js
var gulp = require('gulp');
var git = require('gulp-git');
gulp.task('push', function(){
console.log("Calling git.push()");
git.push('origin', 'master', function (err) {
console.log("In callback of git.push()");
if (err) throw err;
console.log("done");
});
});
gulp.task('default',['push']);
Output
C:\gulp-git>gulp
[23:26:42] Using gulpfile gulp-git\gulpfile.js
[23:26:42] Starting 'push'...
Calling git.push()
[23:26:42] Finished 'push' after 821 μs
[23:26:42] Starting 'default'...
[23:26:42] Finished 'default' after 6.16 μs
As you can see, the callback for git.push()
isn't called.
from gulp-git.
I'm experiencing the same issue. My use case was trying to push a tag from my gulp build, but essentially I'm encountering the same problem as @LarryBattle .
from gulp-git.
Just fixed push.js
, it appears that I did not change it fully from the older requirement of gulp.src
.
from gulp-git.
@LarryBattle can you pull from master and confirm the fix works for you?
from gulp-git.
@stevelacy It works now. Thanks!
For the other lib files, I recommend removing through.obj(write, flush)
and just returning exec()
. MUCH easier to understand.
from gulp-git.
@LarryBattle I'll do it to the ones which don't require a stream, if you want you can open issues for each one to remind me.
from gulp-git.
Published to 0.5.3, thanks
from gulp-git.
Related Issues (20)
- Get current branch name? HOT 2
- git add is broken in Node 8 HOT 1
- git.add does not allow for specified files to add in another cwd HOT 4
- gulp-git breaks in Node 9.5.0. HOT 3
- Error creating commit on new git version HOT 20
- Error: i can't commit HOT 2
- How to use git clone with ssh HOT 2
- How to clone with a specified branch? HOT 5
- commit() will commit also unstaged files HOT 2
- Git add . all files HOT 2
- Cannot use '-a' anymore for commit HOT 4
- how can I checkout a file HOT 1
- stdout maxBuffer length exceeded (diff.js) HOT 1
- Problem with absolute path or Gulp v4
- Cherry-pick - feature request HOT 1
- finish event listener registration error
- Gulp 4 compatibility HOT 1
- Add rebase command HOT 2
- "The command line is too long." on `git.add()` HOT 1
- lodash.template critical vulnerabilities from Mend HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gulp-git.