Can't get push.js to work.

[LarryBattle]

Can't get push.js to work.

[stephenlacy]

Why would the flush function not get called?
Does the console show the git command getting executed?

[LarryBattle]

Here's sample code.

Environment setup.

git clone https://github.com/stevelacy/gulp-git.git
cd gulp-git
echo "test" > new_file.txt
git add . -A
git commit -m "Added new file"
npm install

gulp-git/gulpfile.js

var gulp = require('gulp');
var git = require('gulp-git');

gulp.task('push', function(){
  console.log("Calling git.push()");
  git.push('origin', 'master', function (err) {
    console.log("In callback of git.push()");
    if (err) throw err;
    console.log("done");
  });
});

gulp.task('default',['push']);

Output

C:\gulp-git>gulp
[23:26:42] Using gulpfile gulp-git\gulpfile.js
[23:26:42] Starting 'push'...
Calling git.push()
[23:26:42] Finished 'push' after 821 μs
[23:26:42] Starting 'default'...
[23:26:42] Finished 'default' after 6.16 μs

As you can see, the callback for git.push() isn't called.

[sparty02]

I'm experiencing the same issue. My use case was trying to push a tag from my gulp build, but essentially I'm encountering the same problem as @LarryBattle .

[stephenlacy]

Just fixed push.js, it appears that I did not change it fully from the older requirement of gulp.src.

[stephenlacy]

@LarryBattle can you pull from master and confirm the fix works for you?

[LarryBattle]

@stevelacy It works now. Thanks!
For the other lib files, I recommend removing through.obj(write, flush) and just returning exec(). MUCH easier to understand.

[stephenlacy]

@LarryBattle I'll do it to the ones which don't require a stream, if you want you can open issues for each one to remind me.

[stephenlacy]

Published to 0.5.3, thanks