Commit doesn't fire `end`

[bfricka]

Commit doesn't fire `end`

[gpleiss]

+1. We're running into the same problem.

[max-mykhailenko]

The same problem, please fix it. It's also doesn't work in runSequence

[stephenlacy]

@bfricka PR welcome

[bfricka]

I'll submit something tomorrow or this weekend. Thanks

[chmontgomery]

👍

[openjck]

+1

[icvitkovac]

++

[jlukic]

++

[stephenlacy]

@bfricka do you want to send the PR?

[bfricka]

Thanks for bringing this up. I had totally forgotten. I'll try to put one out tonight.

[am]

Will this work for git.exec also?

[stephenlacy]

Sorry for the long wait - I just hack-patched gulp-git as through2 was not fixed.

[stringparser]

Great, did you report it?

[stephenlacy]

@stringparser I was about to, but they closed 2 other issues regarding it.

[stringparser]

@stevelacy thanks, I've been looking at rvagg/through2#37. It seems intended, the workaround is to call resume if the stream is not piped anywhere else it will be paused, I forgot that.

[stephenlacy]

Indeed, in gulp plugins case it does not make sense to have the users add that.