Vignette depends on ashr

[ramanshah]

Vignette depends on ashr

[stephens999]

True. Not sure how to resolve this. Is there a standard way?
If we install a package from cran then I guess it automatically installs all
dependencies, but from github that doesn't happen. I guess I could
change the readme to say install_github ashr too....

[stephens999]

i modified the readme to include instructions to install ashr

[ramanshah]

Thanks!

Also, just to document the dependency tree (given my relatively clean installation), the vignettes want dplyr as well.

[stephens999]

I have dplyr listed in Imports in the DESCRIPTION file. Do I have to do
something else?

On Fri, Apr 17, 2015 at 2:25 PM, Raman Shah [email protected]
wrote:

Thanks!

Also, just to document the dependency tree (given my relatively clean
installation), the vignettes want dplyr as well.

—
Reply to this email directly or view it on GitHub
#32 (comment).

[ramanshah]

I'll look into this!

[ramanshah]

Ahhh...looks like you imported plyr and not dplyr.

[stephens999]

thx, i updated this

[stephens999]

@ramanshah do you think we can close this issue now?

[stephens999]

i did find this relevant issue
r-lib/devtools#190

[ramanshah]

Yep, it does seem tricky. Let's close it; modulo the above, there may be a challenge when it comes time to send it to CRAN, but we'll see.