Comments (7)
Shares a lot in common with the frustrations voiced in #20. We may need @torkelo to weigh in on what may be the best way to get a particular panel out of the returned result set from the API with a unique identifier that doesn't "move" once created.
/cc @Tenzer
Relevant code: https://github.com/stephenyeargin/hubot-grafana/blob/master/src/grafana.coffee#L120-L130
from hubot-grafana.
I thought hubot grafana used the panel id
from hubot-grafana.
@torkelo It used to do that, but that was changed in #17 in order to make it easier to find the specific panel you want.
I find the current way of working to be most intuitive, but it may depend on how you normally use the feature. For me/us we don't post the same graph regularly, it's basically only something we do when we want to show our colleagues some specific finding in a specific graph, and in those cases I find it to be easier to either use the name or the number (not ID) of the graph.
It may of course also depend on the amount of graphs which is on each dashboard.
If we want to add support for specifying either the ID or the number of the graph, then it's going to tie into the parsing of panel number and search term which is here: https://github.com/stephenyeargin/hubot-grafana/blob/master/src/grafana.coffee#L60-L67.
from hubot-grafana.
So I suppose it will come down to a few things:
panelId
isn't exposed in the interface (that I'm aware of, short of in the URL), so we would need to include it in the output of a dashboard somehow in case they want to commit it to memory- Should we change the default
<dashboard>:<integer>
behavior to usepanelID
, or opt for<dashboard>:panel-<integer>
for the canonical identifier and the integer format as the "optical" panel identifier.
from hubot-grafana.
For what it's worth, I've updated the README in #29 to reflect the current optical identification. I can still see a use for having another processing fork for retrieving by the panelID
as well.
from hubot-grafana.
Any kind of switch or option to choose between real and visual ID would be hugely appreciated!
from hubot-grafana.
Fixed with v1.4.9
from hubot-grafana.
Related Issues (20)
- graf db nginx-lua Why is the grafana homepage returned? HOT 8
- TimeZone support HOT 2
- Grafana 7: Full screen leads to localhost:3000 redirect HOT 4
- ERROR SyntaxError: Unexpected token < in JSON at position 0 HOT 3
- hubot-grafana does not work for Grafana 8 HOT 7
- Upgrade from 2.5.2 to 3.0.1: dashboards can't be accessed by slug anymore HOT 5
- Can only receive 1 image by each query which queries all panels in the dashboard HOT 2
- Allow the bot to respond in a thread HOT 2
- S3 Region breaks existing setup HOT 2
- Support for @hubot-friends/hubot-slack
- feat: clean the NPM package to make its footprint smaller
- Getting rid of the obsolete request dependency
- Tests are too slow or timing out HOT 2
- Refactor platform specific actions to adapters? HOT 3
- Download method needs API key in header HOT 3
- [Windows] Unable to run `npm test` HOT 4
- Let's do some big refactoring
- Typings
- Bot will respond multiple times when Grafana is a bit slow
- Slack upload fails with `TypeError: this.robot.adapter.client.web.files.uploadV2 is not a function`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hubot-grafana.