Giter Site home page Giter Site logo

Comments (7)

stephenyeargin avatar stephenyeargin commented on September 23, 2024

Shares a lot in common with the frustrations voiced in #20. We may need @torkelo to weigh in on what may be the best way to get a particular panel out of the returned result set from the API with a unique identifier that doesn't "move" once created.

/cc @Tenzer

Relevant code: https://github.com/stephenyeargin/hubot-grafana/blob/master/src/grafana.coffee#L120-L130

from hubot-grafana.

torkelo avatar torkelo commented on September 23, 2024

I thought hubot grafana used the panel id

from hubot-grafana.

Tenzer avatar Tenzer commented on September 23, 2024

@torkelo It used to do that, but that was changed in #17 in order to make it easier to find the specific panel you want.

I find the current way of working to be most intuitive, but it may depend on how you normally use the feature. For me/us we don't post the same graph regularly, it's basically only something we do when we want to show our colleagues some specific finding in a specific graph, and in those cases I find it to be easier to either use the name or the number (not ID) of the graph.
It may of course also depend on the amount of graphs which is on each dashboard.

If we want to add support for specifying either the ID or the number of the graph, then it's going to tie into the parsing of panel number and search term which is here: https://github.com/stephenyeargin/hubot-grafana/blob/master/src/grafana.coffee#L60-L67.

from hubot-grafana.

stephenyeargin avatar stephenyeargin commented on September 23, 2024

So I suppose it will come down to a few things:

  • panelId isn't exposed in the interface (that I'm aware of, short of in the URL), so we would need to include it in the output of a dashboard somehow in case they want to commit it to memory
  • Should we change the default <dashboard>:<integer> behavior to use panelID, or opt for <dashboard>:panel-<integer> for the canonical identifier and the integer format as the "optical" panel identifier.

from hubot-grafana.

stephenyeargin avatar stephenyeargin commented on September 23, 2024

For what it's worth, I've updated the README in #29 to reflect the current optical identification. I can still see a use for having another processing fork for retrieving by the panelID as well.

from hubot-grafana.

ShonM avatar ShonM commented on September 23, 2024

Any kind of switch or option to choose between real and visual ID would be hugely appreciated!

from hubot-grafana.

stephenyeargin avatar stephenyeargin commented on September 23, 2024

Fixed with v1.4.9

from hubot-grafana.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.