[Rocketchat] _ERROR SyntaxError: Unexpected token

[stephenyeargin]

[Rocketchat] _ERROR SyntaxError: Unexpected token

[stephenyeargin]

👍 It appears to be something defined for the lower level SDK. I agree the URL is a much cleaner way to define it. The "fix" for this bug (aside from defining the ROCKETCHAT_HOST with the scheme) is to see if we can handle the error a bit more gracefully than the SyntaxError it throws when encountering the redirect.

[stephenyeargin]

@mfilotto Have a second to help us understand what might be going on here?

[mechko]

I just had the same issue und found the cause for my case: The hubot-grafana coffee scripts tries to login to Rocket.Chat using an URL that is prefixed with http:// instead of https://. For our configuration this will lead to an HTTP 301 (redirecting to the https endpoint) and a response document with HTML in it, which is then parsed to JSON - which fails with the error message above.

I configured my Hubot Rocket.Chat adapter using ROCKETCHAT_URL=chat.myhost.com and ROCKETCHAT_USE_SSL=true, but this is obviously ignored by hubot-grafana.

So I changed the the value of ROCKETCHAT_URL to https://chat.myhost.com and now hubot-grafana is using the correct protocol.

[stephenyeargin]

@mechko I think we can rely on whatever settings are needed by the Rocket.Chat adapter, given this is an integration specific to that platform. Do you think we should leverage ROCKETCHAT_USE_SSL for easier set up?

[mfilotto]

I think we should stick to URL definition: scheme:[//authority]path[?query][#fragment]
If so the protocol should be specify, even if the default is http if not specify.

Otherwise we could add these two variables ROCKETCHAT_HOST and ROCKETCHAT_USE_SSL