detects properties without contents as diff

[sters]

detects properties without contents as diff

[sters]

@dionysius

The fact that the key is there doesn't change even if there is an empty field. It's diff as a YAML document.

But I know k8s and other tools will ignore empty values and perform as default. So maybe it's better to make an option such as --ignore-empty-fields.

[dionysius]

Yeah, the existence of a key may have a meaning and should be treated as such. ignore-empty-fields sounds like a good compromise.

Although since we defined now that additional keys trigger a diff, that should also happen on creationTimestamp

[sters]

@dionysius
Updated. https://github.com/sters/yaml-diff/releases/tag/v1.1.0

You can do:

diffs := yamldiff.Do(yamlSource, yamlParsed, yamldiff.EmptyAsNull())

and diff result is:

  apiVersion: "v1"
  kind: "Pod"
  metadata:
    namespace: "default"
    name: "nginx"
    creationTimestamp:
  spec:
    containers:
      -
        name: "nginx"
        image: "nginx"
        resources:
  status:

Also, I added Status field in diff struct. You can refer to this field to detect whether there is diff or not. So you can do:

diffs := yamldiff.Do(yamlSource, yamlParsed, yamldiff.EmptyAsNull())

fail := false
for _, diff := range diffs {
	if diff.Status() != yamldiff.DiffStatusSame {
		fail = true
		t.Log("diff detected\n" + diff.Dump())
	}
}

if fail {
	t.Fail()
}

[dionysius]

Thanks for everything. Will check and report!

[sters]

If you have more conversation, please reopen (or recreate) issue.