Comments (5)
The fact that the key is there doesn't change even if there is an empty field. It's diff as a YAML document.
But I know k8s and other tools will ignore empty values and perform as default. So maybe it's better to make an option such as --ignore-empty-fields
.
from yaml-diff.
Yeah, the existence of a key may have a meaning and should be treated as such. ignore-empty-fields
sounds like a good compromise.
Although since we defined now that additional keys trigger a diff, that should also happen on creationTimestamp
from yaml-diff.
@dionysius
Updated. https://github.com/sters/yaml-diff/releases/tag/v1.1.0
You can do:
diffs := yamldiff.Do(yamlSource, yamlParsed, yamldiff.EmptyAsNull())
and diff result is:
apiVersion: "v1"
kind: "Pod"
metadata:
namespace: "default"
name: "nginx"
creationTimestamp:
spec:
containers:
-
name: "nginx"
image: "nginx"
resources:
status:
Also, I added Status
field in diff struct. You can refer to this field to detect whether there is diff or not. So you can do:
diffs := yamldiff.Do(yamlSource, yamlParsed, yamldiff.EmptyAsNull())
fail := false
for _, diff := range diffs {
if diff.Status() != yamldiff.DiffStatusSame {
fail = true
t.Log("diff detected\n" + diff.Dump())
}
}
if fail {
t.Fail()
}
from yaml-diff.
Thanks for everything. Will check and report!
from yaml-diff.
If you have more conversation, please reopen (or recreate) issue.
from yaml-diff.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yaml-diff.