reserved identifier violation

[steveicarus]

reserved identifier violation

[steveicarus]

Yeah, OK, I guess technically that is true. I'm not going to go through the effort of changing them though. If someone submits a patch that fixes this, then I would apply it.

[steveicarus]

Does anybody find this issue to be important, or can I close it?

[caryr]

I think this should be done if/when we have some spare time. Even better it is the perfect task for someone who wants to help out, but does not want to tackle learning the code base. I am guessing there are other simple rules like this that we have unknowingly violated over the years that could also be addressed.

To me the big issue is preventing these issues from creeping back in since we are all creatures of habit. For example every few months I submit a patch that fixes compilation and cppcheck warnings created by recent patches.

[martinwhitaker]

Fixing the header file identifiers should be easy to automate, and would take care of the bulk of the transgressions. I could take a look at this once the vec4-stack merge is done. As for the rest, I agree with Cary - fix them up as/when we have spare time or are working on that bit of code.

As for other issues that creep in, can we add an automatic pre-commit check to catch some of these? I'm thinking particularly of white space errors - I always mean to check for these before committing, but don't always remember.

[caryr]

I have pushed a patch that updates all the header file protection code to use IVL_ as the prefix instead of __.

[elfring]

Thanks for your source code improvement.

[elfring]

How do you think about to reconsider also the use of a prefix like "__vpi" in your source code?

[steveicarus]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/26/2015 02:10 PM, Markus Elfring wrote:

How do you think about to reconsider also the use of a prefix like
"|__vpi|" in your source code

iverilog/vvp/vpi_priv.h

Line 96 in 62abb19

/*

?

The

specific example of the __vpiHandle class is probably something
that could stand to be changed. If anybody comes up with a patch,
I'd be willing to check it for approval.

---

Steve Williams "The woods are lovely, dark and deep.
steve at icarus.com But I have promises to keep,
http://www.icarus.com and lines to code before I sleep,
http://www.picturel.com And lines to code before I sleep."
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlUUfPwACgkQrPt1Sc2b3infGwCeK+8Ms5lAFzmkEcFGVWrxw8MD
INgAoOZS8A+YSypStp+XeD4TNhETh/As
=FisT
-----END PGP SIGNATURE-----

[elfring]

How do you think about to replace such a questionable prefix by a standard-compliant name space?