Comments (2)
This is done for performance. If all commands have the same signature they can be stored as Action<CommandArg[]>
objects, this way the methods can be called with comparable overhead to calling them directly in C#.
Allowing different signatures would require the command methods to be stored as MethodInfo
objects and be invoked at run-time with reflection, which is significantly slower than the delegate version (~20x slower in my testing).
I figured the readability trade off was worth it for the performance gains. Letting the arguments be parsed in the command method lets you parse types of Vector3, Color, etc. on your front end code, instead of having a parser that accounts for every type people would want to use.
I really wanted to have proper parameters in commands like in your example, but I don't see a way to do it that doesn't compromise performance, or accounts for custom types.
from command_terminal.
Although invoking a MethodInfo
is much slower than an Action<CommandArg[]>
, I'm not sure the performance difference is really relevant for this situation. Computers are just so fast that the user won't ever notice the difference.
Your points about standardizing parsing logic for command input are very good, however.
from command_terminal.
Related Issues (20)
- Mobile Device Support? HOT 7
- unclear
- AddCommand don't add autocompletion all the times HOT 3
- Deleting commands? HOT 4
- never assigned to warnings
- CVARS feature? HOT 1
- move cursor at end not working when pressing UP key HOT 1
- Static methods not called if asset is in the /Plugins/ folder HOT 2
- BUG Background isn't rendered. (workaround) HOT 2
- in webgl all commands have command prefix in runtime
- Terminal background is transparent
- How to make command group? HOT 1
- Is there a way to avoid displaying the Debug.Log? HOT 1
- Typing is not showing up HOT 1
- Binding hotkey to F1-F12 doesn't register first letter in input HOT 2
- Can you updates to Input System supports?
- Command groups idea HOT 10
- Command usage tip? HOT 4
- Readme suggestions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from command_terminal.