Giter Site home page Giter Site logo

Comments (34)

OskarD avatar OskarD commented on May 12, 2024 24

It seems to be working in 3.5.0-alpha.0

from react-spring-bottom-sheet.

novaladip avatar novaladip commented on May 12, 2024 14

the issue is still there "react": "^18.2.0", "react-dom": "^18.2.0", "react-spring-bottom-sheet": "3.5.0-alpha.0"

it's working fine on me, maybe try to remove the node_modules folder then run npm install again?

my package.json
"react": "18.2.0",
"react-dom": "18.2.0",
"react-spring-bottom-sheet": "3.5.0-alpha.0",

from react-spring-bottom-sheet.

howlettt avatar howlettt commented on May 12, 2024 8

Ran into the same issue, looks like it's a issue with React v18 StrictMode, removing StrictMode or running a prod build it works fine.
https://reactjs.org/blog/2022/03/29/react-v18.html#new-strict-mode-behaviors

from react-spring-bottom-sheet.

joshuaellis avatar joshuaellis commented on May 12, 2024 4

Well the package here is locked to version 8 API, so it probably needs a good update to be working with react18 & react-spring9

Id try talk to the maintainer or update the lib and submit a PR.

from react-spring-bottom-sheet.

AyushSaini00 avatar AyushSaini00 commented on May 12, 2024 4

it worked by disabling the react strict mode on nextjs 13.

from react-spring-bottom-sheet.

AshMW2724 avatar AshMW2724 commented on May 12, 2024 3

@joshuaellis I have gone ahead and made the changes needed to upgrade to react-spring v9.4.5

from react-spring-bottom-sheet.

klanthier avatar klanthier commented on May 12, 2024 3

Same here, latest version (3.4.1) on react 18 still triggers the same issue.
Running on NextJS if that helps

from react-spring-bottom-sheet.

joshuaellis avatar joshuaellis commented on May 12, 2024 2

I actually launched a new version of react-spring that works with r18, so I think this project would need to update its deps accordingly 👌🏻 9.4.5 for reference.

from react-spring-bottom-sheet.

SebastienSusini avatar SebastienSusini commented on May 12, 2024 2

I still have the issue with the last version, any ideas ?

from react-spring-bottom-sheet.

howlettt avatar howlettt commented on May 12, 2024 2

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

from react-spring-bottom-sheet.

alexchavero avatar alexchavero commented on May 12, 2024 1

Thanks joshuaellis, I uninstalled the react-spring-bottom-sheet package and re-installed it. Then checked the react-spring version and is now the 9.4.5 you mentioned; but I still getting the same error: TypeError: Cannot read properties of undefined (reading 'getValue'). The error is in the localhost only, in production works fine.

Did I missed something else that you can help me please?

from react-spring-bottom-sheet.

kthehatter avatar kthehatter commented on May 12, 2024 1

i guess still no solution for this issue i'm having this issue as well on nextjs 13

from react-spring-bottom-sheet.

howlettt avatar howlettt commented on May 12, 2024

Looks like react-spring doesn't support React v18 yet
pmndrs/react-spring#1563

from react-spring-bottom-sheet.

joshuaellis avatar joshuaellis commented on May 12, 2024

I've launched a beta for react18 that should resolve issues and be good to go – 9.4.5-beta.1 please feel free to give it a go and any issue feedback on that issue you linked too :)

from react-spring-bottom-sheet.

ivanoliveiraitez avatar ivanoliveiraitez commented on May 12, 2024

How i do access the beta version?

from react-spring-bottom-sheet.

alexchavero avatar alexchavero commented on May 12, 2024

I would like to try the beta also, where can I download it? thanks

from react-spring-bottom-sheet.

maxizhukov avatar maxizhukov commented on May 12, 2024

Have same while migrated from react to nextjs, react 18.2.0, but was working fine with 17

from react-spring-bottom-sheet.

treyhuffine avatar treyhuffine commented on May 12, 2024

I'm having the same issue as well. Let me know if there is anything I can do to help resolve it.

from react-spring-bottom-sheet.

odafeaggreh avatar odafeaggreh commented on May 12, 2024

Please has a solution to this been discovered? I'm having the same issue now

from react-spring-bottom-sheet.

mard0n avatar mard0n commented on May 12, 2024

the issue is still there
"react": "^18.2.0", "react-dom": "^18.2.0", "react-spring-bottom-sheet": "3.5.0-alpha.0"

from react-spring-bottom-sheet.

nazaninroozbahani avatar nazaninroozbahani commented on May 12, 2024

I have the same issue. It's also working in version 3.5.0-alpha.0.
Why not release the original version?

from react-spring-bottom-sheet.

unmanned-harry avatar unmanned-harry commented on May 12, 2024

Same issue here

from react-spring-bottom-sheet.

precz avatar precz commented on May 12, 2024

🆙

from react-spring-bottom-sheet.

nadiannis avatar nadiannis commented on May 12, 2024

I got the same problem.

My dependencies:

"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-spring-bottom-sheet": "^3.4.1"

from react-spring-bottom-sheet.

ramirez411 avatar ramirez411 commented on May 12, 2024

I got the same error with:

"react": "18.2.0",
"react-dom": "18.2.0",
"react-spring-bottom-sheet": "^3.4.1".

I am looking for other options to do the same, instead I´ll try to use this: https://www.npmjs.com/package/react-modal-sheet

I would appreciate if other people have more options.

from react-spring-bottom-sheet.

ramirez411 avatar ramirez411 commented on May 12, 2024

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Thanks

from react-spring-bottom-sheet.

joaolfern avatar joaolfern commented on May 12, 2024

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Very nice animations, but I unfortunately couldn't figure out how to use it with JSX

from react-spring-bottom-sheet.

kiki-le-singe avatar kiki-le-singe commented on May 12, 2024

I would like to use this package, but unfortunately it doesn’t work...

"next": "13.4.5",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-spring-bottom-sheet": "^3.4.1" | "3.5.0-alpha.0" 

from react-spring-bottom-sheet.

howlettt avatar howlettt commented on May 12, 2024

Haven't tried it yet, but this seems similar https://github.com/roman-rr/cupertino-pane

Very nice animations, but I unfortunately couldn't figure out how to use it with JSX

tech-systems/panes#142 (comment)

from react-spring-bottom-sheet.

Franjoo avatar Franjoo commented on May 12, 2024

⬆️ Same issue here, any updates on that?

from react-spring-bottom-sheet.

dong-nguyen avatar dong-nguyen commented on May 12, 2024

I still facing this issue when upgrading to Next.js 14. it works fine on Next.js 13.4 before.

from react-spring-bottom-sheet.

qasimgit avatar qasimgit commented on May 12, 2024

Same here, getting this error in Next 14, has anyone found any solution?

from react-spring-bottom-sheet.

lucasromerodb avatar lucasromerodb commented on May 12, 2024

It seems to be working in 3.5.0-alpha.0

Be careful with 3.5.0-alpha.0 version, it installs a lot of new dependencies who has at least 5 high vulnerabilities that allows SSRF attacks. Learn more here

from react-spring-bottom-sheet.

Stokel avatar Stokel commented on May 12, 2024

3.5.0-alpha.0 gets rid of the error for me but introduces scrolling bugs on mobile iOS. The first touch/scroll is always way too fast. Anyone has the same problems and a workaround for this?

It also introduces a bug which closes the bottom sheet for us during scrolling a long list before reaching the top.

from react-spring-bottom-sheet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.