Management of Required and ReadOnly with Array does not work correctly

[LasneF]

Management of Required and ReadOnly with Array does not work correctly

[ilanashapiro]

sounds good and fortunately I was actually able to do it for tuple typed arrays as well, which is all in the PR!

[ilanashapiro]

Hi! I am working on this issue and I have a quick question. I have what I think is a working solution for non-tuple typed arrays (i.e., arrays where every elements conforms to a single schema, like:

objectsArray: {
          type: 'array',
          items: {
            type: 'object',
            required: ['id', 'name'],
            properties: {
              id: {
                readOnly: true,
                type: 'string'
              },
              name: {
                type: 'string'
              }
            }
          }
        },

However, as I continue trying to implement the fix for tuple-typing, it has proven to be much more difficult (i.e. multiple schema corresponding to individual array items, like:

objectsArray: {
          type: 'array',
          items: [
            { 
              type: 'object', 
              required: ['id1, 'name'], 
              properties: { id: { readOnly: true, type: 'string' }, name: { type: 'string' } } 
            },
            { 
              type: 'object', 
              required: ['address', 'title'2], 
              properties: { address: { readOnly: true, type: 'string' }, title: { type: 'string' } } 
            }
          ]
        },

@rattrayalex I can submit the solution for the non-tuple typed arrays in the next day or so -- would you like me to continue working on the tuple typed cases after this? Thanks!
(edit: happy to continue working on it, just want to make sure you can get at least a partial solution more quickly)

[chohmann]

Could also be an issue if Dog is a property of another object. Need to check this case as well.

[LasneF]

@chohmann tested with Dog as a property of another Object the bug looks not there !

see below spec

• /dogSingle + { "name" = "happy" } => no issue
• /dogInABox => no issue { "inside" : { "name" : "alsoHappy" } } => no issue
• /dogs => Bug + { "dogs" : [{"name" = "sad" }] =>bug report id as mandatory

if i send wrong payload such as a dog like this "nane" : "typo"

• both dogSingle and dogInABox return name is mandatory
• dogs return that name AND id is mandatory

openapi: 3.1.0

paths:
  /dogs:
    post:
      requestBody:
        content:
          application/json:
            schema:
                $ref: '#/components/schemas/Dogs'
      responses:
        '200':
          description: nice Dog
  /dogSingle:
    post:
      requestBody:
        content:
          application/json:
            schema:
                $ref: '#/components/schemas/Dog'
      responses:
        '200':
          description: nice Dog
  /dogInABox:
    post:
      requestBody:
        content:
          application/json:
            schema:
                $ref: '#/components/schemas/BoxDog'
      responses:
        '200':
          description: nice Dog


  
components:
  schemas:
    Dogs:
        type: object
        properties:
            dogs:
              type: array
              items:
                $ref : "#/components/schemas/Dog"
    
    Dog:
        type: object
        required:
            - id
            - name
        properties:
            id:
              readOnly: true
              type: string
            name:
              type: string
    BoxDog:
      type: object
      required: inside
      properties:
        inside :
            $ref : "#/components/schemas/Dog"

[rattrayalex]

Sure, a follow-on PR with the other fixes sounds like something we'd be happy to sponsor!