Giter Site home page Giter Site logo

Comments (15)

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024 2

At first glance everything looks amazing, we will investigate further and let you know our final feedback.

Thanks a ton!

from react-treebeard.

maximilianoforlenza avatar maximilianoforlenza commented on July 23, 2024

Hi @mindaugasnakrosis! Do you want to expand the row when the mouse is hover on it?

from react-treebeard.

RokasVaitkevicius avatar RokasVaitkevicius commented on July 23, 2024

@maximilianoforlenza Current problems is that expand node and select it, are the same operations currently. Would it be possible to separate them?

What I mean by that is only expanding the node, but not selecting it and other way around, clicking on it, selecting it, but not expanding/closing it.

Basically is it possible to do it like in this gif? This is done using another library.

ezgif com-video-to-gif

from react-treebeard.

maximilianoforlenza avatar maximilianoforlenza commented on July 23, 2024

@RokasVaitkevicius what library is that?

from react-treebeard.

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024

@maximilianoforlenza https://github.com/chenglou/react-treeview

But it is not maintained anymore, so difficult to use.

from react-treebeard.

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024

We need the ability to:

  • expand the node (one action)
  • select the row (another action)

from react-treebeard.

maximilianoforlenza avatar maximilianoforlenza commented on July 23, 2024

ok. Yes it is possible. I'll start to work on it.

from react-treebeard.

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024

@maximilianoforlenza amazing! Looking forward to the changes.

from react-treebeard.

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024

@maximilianoforlenza how is it going? Maybe you need some help?

from react-treebeard.

maximilianoforlenza avatar maximilianoforlenza commented on July 23, 2024

hi @mindaugasnakrosis ! I've published a new release https://github.com/storybookjs/react-treebeard/releases/tag/v4.2.4-beta.0 this is a beta version.

Now you have a new prop called onSelect this prop send the node selected. Here is an example https://github.com/storybookjs/react-treebeard/blob/master/example/app.js and you have customStyles prop if you want to change the title color.

please give me your feedback, if is ok I'll fix test and I'll publish stable version.

from react-treebeard.

mindaugasnakrosis avatar mindaugasnakrosis commented on July 23, 2024

@maximilianoforlenza everything is perfect! Thanks again, will be closing it now.

from react-treebeard.

maximilianoforlenza avatar maximilianoforlenza commented on July 23, 2024

@mindaugasnakrosis Thanks! I'll fix the unit test and then I'll publish a new version (5.0.0).

from react-treebeard.

mhlmhl avatar mhlmhl commented on July 23, 2024

Is this new version published? I have version 3.2.4 and onSelect doesn't work. And I don't see onSelect in the ReadMe, either.

from react-treebeard.

RokasVaitkevicius avatar RokasVaitkevicius commented on July 23, 2024

If you want to have it, you have to use version "^4.2.4-beta.0". It has onSelect and onToggle separated and available. I don't know when it will be published and go out of beta.

from react-treebeard.

mhlmhl avatar mhlmhl commented on July 23, 2024

Thanks for the hint. It works well! (Correction of the previous version of this comment.)

I appreciate the new function.

from react-treebeard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.