Giter Site home page Giter Site logo

build-storybook error about addon-jsx HOT 8 CLOSED

storybookjs avatar storybookjs commented on August 24, 2024
build-storybook error

from addon-jsx.

Comments (8)

wcastand avatar wcastand commented on August 24, 2024 1

Yeah, that way people who came across the same problem will know why :)
I hope it get fixed soon.
Thank, for reporting the bug here :)

from addon-jsx.

ndelangen avatar ndelangen commented on August 24, 2024 1

passing to babel-minify should fix the issue. The package react-element-to-jsx-string use a dependency that do not transpile to es5 anymore.

This is on the way:
storybookjs/storybook#1733

from addon-jsx.

nicolaskruchten avatar nicolaskruchten commented on August 24, 2024

I should add that 1) this is an awesome addon and 2) it works with start-storybook in my setup, just not with build-storybook :)

from addon-jsx.

nicolaskruchten avatar nicolaskruchten commented on August 24, 2024

How to replicate:

  1. clone this: https://github.com/plotly/react-pivottable/tree/jsx-addon-bug
  2. npm install
  3. npm run build-storybook

from addon-jsx.

wcastand avatar wcastand commented on August 24, 2024

The response you got from the issue in storybook kind of answer to you i think no ? or you want something in particular ?

passing to babel-minify should fix the issue. The package react-element-to-jsx-string use a dependency that do not transpile to es5 anymore.

If you think there is a way to avoid this problem, i don't mind looking into it:).

from addon-jsx.

nicolaskruchten avatar nicolaskruchten commented on August 24, 2024

Well, until the upstream patch is merged, this is still a big problem: we can't use this addon with build-storybook so let's keep this issue open until it's fixed upstream?

from addon-jsx.

Hypnosphi avatar Hypnosphi commented on August 24, 2024

passing to babel-minify should fix the issue

But only if you're not targeting IE11

from addon-jsx.

markagrover avatar markagrover commented on August 24, 2024

I fixed the issue after lots of complication.

some plugins will add their own version of storybook as a dependency. Delete that if it pops up. Also this will go for most plugins I'm guessing. But in this plugin, I went into the plugin files and replaced a couple calls from @storybook/addons to @kadira/storybook-addons the changes were in files lib/index and lib/register. anywhere you see this pattern of calls to external files you will have to follow the errors and make the changes.

Happy coding!!!

from addon-jsx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.