fatal: no tag exactly matches 'id'

[stovmascript]

fatal: no tag exactly matches 'id'

[stovmascript]

Looks like HEAD isn't pointing to any Git tag. Is that correct?

Thought: Maybe RNV should just skip adjusting Git tags when it doesn't find any, instead of throwing.

[VinceBT]

Yes you are maybe correct. Such a behaviour would be great

[stovmascript]

@VinceBT New version (2.6.1) is out now on npm.

[VinceBT]

I used --amend to try your modification and got the same error, I'm on 2.6.1
Could the && be the reason of the bug here ? :

react-native-version/index.js

Line 507 in f5228b0

) &&

EDIT: Changing it to || did nothing

[stovmascript]

Hm, weird. Here's what I just tried:

$ npm version patch
$ react-native-version -a
# commit amended, git tag adjusted

$ npm version patch
# another test commit
$ react-native-version -a
# commit amended, no git tag adjusted

LGTM

[VinceBT]

Could you reopen this issue ? I still don't have the amend working even with latest version :(

[stovmascript]

I'm going to need a reproducible example in order to dig deeper.

From your description I gather that you have something like a monorepo with multiple projects or apps in it. This shouldn't be a problem. However, about Git tags... Do you utilize them somehow in the other apps? Do you skip tag creation (--no-git-tag-version or disabling in npm config) when using npm version ... or are you using default settings?

AFAIK Git tags are global inside a repo, so they can be overwritten by the other apps.

[VinceBT]

I think my issue is related to this npm/npm#9111

Since my app is inside a subfolder, it doesnt not create a tag, so there is nothing to amend.

I've adapted my package.json to look like that:

But when using npm version, it creates two tags now:

EDIT:
I think this ticket can be closed and a second known issue can be added to your readme haha
If you can help me on the double tag issue tell me if I need to create a second issue of if there is a simple fix

[stovmascript]

Hm, wasn't aware of this. Maybe a check that Git exists in that directory should also be added. npm version simply skips tag creation if there isn't a .git/ directory. I think we should mirror that behaviour.

[stovmascript]

@VinceBT Can you try out react-native-version@next (2.6.3-0) and see if that works ok?

[VinceBT]

When using your new version I get this output and no git tag

[RNV] Versioning Android...
[RNV] Android updated
[RNV] Versioning iOS...
[RNV] iOS updated
[RNV] Amending...
[RNV] Done

But when creating a .git folder, I get this output and a git tag

[RNV] Versioning Android...
[RNV] Android updated
[RNV] Versioning iOS...
[RNV] iOS updated
[RNV] Amending...
[RNV] Adjusting Git tag...
[RNV] Done

The [RNV] Adjusting Git tag... step is triggered in the second case
I dont have the double tag issue anymore

[stovmascript]

Yeah, but isn't that what we want?

With "preversion": "mkdir .git", when you run npm version and the Git tag for that version does not exist in your repo, it will create the tag and proceed with "postversion": "react-native-version --amend", which will find the tag and adjust it to point to the amended commit.

If the Git tag already exists in the repo, npm version will throw an error because it does not use the --force option like RNV does.

---

But I have found and issue in the case when there is no .git/ folder, npm version will skip creating a Git tag and will not even commit the changes in package.json. RNV will then do its work and amend the current commit in error. The same commit validation we do for determining when to search for Git tags should be added before amending.

[christophliftoff]

For me this was happening when I would try and run the react-native-version script without committing my changes. It seems that you can only run this script once per commit? Otherwise I'd get the error you shared above.

[arafatalim]

I fixed the problem by adding the missing .git folder to the apps/mobile folder.

Q. How can I check if my folder is missing?
A. I checked on vs code for this.

• Open Settings -> Search or type exclude -> find the pattern **/.git, remove it temporarily, and click ok.
• Check for the .git folder in the main project directory and the apps/mobile folder.
• If the .git folder is not in the apps/mobile folder, create it. [Leave it empty]
• Now, execute your command, like yarn mobile:staging:release.