Giter Site home page Giter Site logo

Comments (6)

suside avatar suside commented on May 5, 2024 1

Not sure, I was testing inside project with

$ npm --version
6.0.1
$ yarn --version
1.6.0

and husky precommit enabled.
I will report back as soon as I figure out who and where exactly is setting those env's.

from react-native-version.

suside avatar suside commented on May 5, 2024 1

Right, another || will definitely do the job.
But since workaround works I'm going to figure out what's going on underneath before doing any PRs.

from react-native-version.

stovmascript avatar stovmascript commented on May 5, 2024

Whoa, nice find! Is it possible that this variable name was also changed in some new version of npm, or is it really yarn only?

from react-native-version.

stovmascript avatar stovmascript commented on May 5, 2024

Well, nevertheless, I think we can just add another || for process.env.npm_config_version_git_tag right?

from react-native-version.

leethree avatar leethree commented on May 5, 2024

I'm seeing the same problem and @suside 's workaround works. Would be great if it can be fixed.

from react-native-version.

suside avatar suside commented on May 5, 2024

So it seems they do have different names
https://github.com/yarnpkg/yarn/blob/master/src/registries/yarn-registry.js#L17
vs
https://github.com/npm/cli/blob/latest/lib/config/defaults.js#L150
I'm not sure why.

It seems that another || would be the best solution indeed.

from react-native-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.