Giter Site home page Giter Site logo

Comments (8)

trackq avatar trackq commented on May 5, 2024 1

Ey amigo!

Something like this? #64

from react-native-version.

trackq avatar trackq commented on May 5, 2024

Fix ready in PR #64

from react-native-version.

stovmascript avatar stovmascript commented on May 5, 2024

Hey @trackq, thanks for the PR!

The problem with this solution is that projects created with create-react-native-app and then ejected to be standard RN apps, will retain the "expo" key in app.json. The expo package on the other hand, will be removed during the process.

But what about checking for both? I think if isExpoProject() returned true when both the expo package is installed and there is an "expo" key in app.json, then it would serve both cases.

from react-native-version.

stovmascript avatar stovmascript commented on May 5, 2024

There's also the issue of supporting older RN apps, which don't have an app.json. I would suggest wrapping the require() in a try...catch block as shown here:

try {
appJSON = require(appJSONPath);

Edit: Although, this is probably a minor issue. I don't think we even have a test for it.

from react-native-version.

trackq avatar trackq commented on May 5, 2024

I also removed the package that caused this. It had expo in it's dependencies, which in turn flagged my whole project as an Expo project.

from react-native-version.

pencilcheck avatar pencilcheck commented on May 5, 2024

Detecting expo project using "expo" key is not enough, I used expo but detached from it, still having app.json but I managed ios/ android/ manually, if it can detect further such as "isDetached" key inside "expo" that would be useful

from react-native-version.

pencilcheck avatar pencilcheck commented on May 5, 2024

Version 2.5.1 works for me for ejected expo projects

from react-native-version.

trackq avatar trackq commented on May 5, 2024

Version 2.5.1 works for me for ejected expo projects

Can't check atm. You need me to check it later on?

from react-native-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.