Comments (3)
@tmchow You shouldn't have to update anything in your Xcode project manually. RNV takes the version number from your package.json
and injects it everywhere, including this variable. Take a look at the test fixtures or init a clean React Native project somewhere to see how to set up your project accordingly.
The thing that might be out of the ordinary, is the 2 targets that you have to build.
If it doesn't work after checking/setting up your project according to the default RN project, could you maybe make a sample repo with a clean RN project and then set the 2 targets similarly to how you have it in your real project?
from react-native-version.
@stovmascript my project was setup originally with the target’s each having a reference to the version defined by the project.
Meaning that the info.plist of each target referenced $(CURRENT_PROJECT_VERSION)
.
When I then ran yarn version
to bump the version number, the targets would not get their version updated properly. It would bump it to NaN
.
So I then changed the references to the current project variable to an absolutel version number (eg. $(CURRENT_PROJECT_VERSION)
-> 1.0.0
).
When I then re-ran yarn version, the version number got bumped correctly but the version in the project wasn’t updated.
from react-native-version.
@tmchow I see now. You're putting the version string (1.0.0
or in iOS speak: CFBundleShortVersionString
) into CURRENT_PROJECT_VERSION
, but React Native puts the build number integer (CFBundleVersion
) into this variable.
I suggest resetting this to match a clean RN project, otherwise RNV won't work properly.
P.S. My test fixture is a bit out of date, but I just checked the RN repo and it's still done the same way.
from react-native-version.
Related Issues (20)
- increse buildNumber on hot reload HOT 1
- Just to verify: there is NO option to NOT let the tool commit into git? HOT 2
- increase with widget targers version
- Command failed with exit code 127
- Support for multiple info plist files?
- npm version [major/minor/patch] is not updating all the files
- I don't want to increase verssion on all Project HOT 2
- fatal: No names found, cannot describe anything. HOT 1
- SUPPORT
- Support iOS Extensions target HOT 2
- Cannot increase only build number
- Change version for a specific IOS target
- Rely on an argument for expo and react-native projects
- versionName and CFBundleShortVersionString dont output the expected inputs
- Fails when xCode has more targets (multiple Info.plis)
- What's an alternative to this package? HOT 2
- Need monorepo support
- How can I also customize updating files to add for example updating OneSignal version and build Id ?
- Add --skip-expo option to skip Expo versioning even if detected HOT 1
- SyntaxError: Expected "\"", "\\'", "\\\"", "\\n", or [^\\"] but "\\" found. HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-version.