Giter Site home page Giter Site logo

Comments (3)

stovmascript avatar stovmascript commented on May 6, 2024

@tmchow You shouldn't have to update anything in your Xcode project manually. RNV takes the version number from your package.json and injects it everywhere, including this variable. Take a look at the test fixtures or init a clean React Native project somewhere to see how to set up your project accordingly.

The thing that might be out of the ordinary, is the 2 targets that you have to build.

If it doesn't work after checking/setting up your project according to the default RN project, could you maybe make a sample repo with a clean RN project and then set the 2 targets similarly to how you have it in your real project?

from react-native-version.

tmchow avatar tmchow commented on May 6, 2024

@stovmascript my project was setup originally with the target’s each having a reference to the version defined by the project.

Meaning that the info.plist of each target referenced $(CURRENT_PROJECT_VERSION).

When I then ran yarn version to bump the version number, the targets would not get their version updated properly. It would bump it to NaN.

So I then changed the references to the current project variable to an absolutel version number (eg. $(CURRENT_PROJECT_VERSION) -> 1.0.0).

When I then re-ran yarn version, the version number got bumped correctly but the version in the project wasn’t updated.

from react-native-version.

stovmascript avatar stovmascript commented on May 6, 2024

@tmchow I see now. You're putting the version string (1.0.0 or in iOS speak: CFBundleShortVersionString) into CURRENT_PROJECT_VERSION, but React Native puts the build number integer (CFBundleVersion) into this variable.

I suggest resetting this to match a clean RN project, otherwise RNV won't work properly.

P.S. My test fixture is a bit out of date, but I just checked the RN repo and it's still done the same way.

from react-native-version.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.