Comments (3)
Hi @jpolo, could you provide an example of the workflow you do with RNV?
Just to be sure we're on the same page, RNV doesn't create a new version. A new version is created by the npm version
command which you should be executing before RNV.
RNV uses git commit -a
in only two situations:
-
When it's executed from the "postversion" script - which is triggered by
npm version
. Make sure you're not running this script manually (npm run postversion
). You can however, add the--never-amend
option and commit the changes yourself. -
When it's executed with the
--amend
option. In this case, there is a clear intent that you want to amend the previous commit. But again, it's expected that you just executednpm version
, which already guards your Git working directory the way you describe.
from react-native-version.
Yes we use in postversion hook with no args. I had some uncommitted unadded changes and I ran yarn version.
In the mean time I saw that we also use a custom changelog hook I'll check this one.
Nevertheless don't you think the git commit all is dangerous without a git status check before?
from react-native-version.
I see the problem now. Unlike npm version
, which checks and aborts if the Git working directory is dirty, yarn version
doesn't care and just makes a version commit. If you have uncommited changes to package.json, it will result in the same situation which you described. That's pretty messy of Yarn if you ask me.
RNV is relying on checks made by npm version
.
Nevertheless, I guess we're gonna have to improve support for Yarn and make our own checks. In the meanwhile, using npm version
should be safe, if you don't mind the missing "v" in its commit message.
from react-native-version.
Related Issues (20)
- increse buildNumber on hot reload HOT 1
- Just to verify: there is NO option to NOT let the tool commit into git? HOT 2
- increase with widget targers version
- Command failed with exit code 127
- Support for multiple info plist files?
- npm version [major/minor/patch] is not updating all the files
- I don't want to increase verssion on all Project HOT 2
- fatal: No names found, cannot describe anything. HOT 1
- SUPPORT
- Support iOS Extensions target HOT 2
- Cannot increase only build number
- Change version for a specific IOS target
- Rely on an argument for expo and react-native projects
- versionName and CFBundleShortVersionString dont output the expected inputs
- Fails when xCode has more targets (multiple Info.plis)
- What's an alternative to this package? HOT 2
- Need monorepo support
- How can I also customize updating files to add for example updating OneSignal version and build Id ?
- Add --skip-expo option to skip Expo versioning even if detected HOT 1
- SyntaxError: Expected "\"", "\\'", "\\\"", "\\n", or [^\\"] but "\\" found. HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-version.