isFaultyImage returns false positive response when `file.filepath` is empty

[dekhanov]

isFaultyImage returns false positive response when `file.filepath` is empty

[joshuaellis]

Can you please feel out reproduction steps.

[dekhanov]

To reproduce the bug you can extend @strapi/plugin-upload. The bug is in the version 4.24.2 of the plugin.

src/extensions/upload/overrides.ts

/**
 * Overriding enhanceAndValidateFile method to validate available file extensions
 * node_modules/@strapi/plugin-upload/server/services/upload.js
 */
import { errors } from '@strapi/utils';
import fs from 'fs';

const { ApplicationError } = errors;
const allowedExtensions = [
  '.jpg',
  '.jpeg',
  '.png',
  '.webp',
  '.svg',
  '.pdf',
  '.mp4',
];

const isFileExtensionAllowed = (fileExtension) => {
  return allowedExtensions.includes(fileExtension);
};

export async function enhanceAndValidateFile(file, fileInfo = {}, metas = {}) {
  // @ts-expect-error this will be available on override
  const currentFile = await this.formatFileInfo(
    {
      filename: file.name,
      type: file.type,
      size: file.size,
    },
    fileInfo,
    {
      ...metas,
      tmpWorkingDirectory: file.tmpWorkingDirectory,
    }
  );
  if (!isFileExtensionAllowed(currentFile?.ext)) {
    throw new ApplicationError(
      `File type is not allowed. Allowed extentions: ${allowedExtensions.join(
        ','
      )}`
    );
  }

  currentFile.getStream = () => fs.createReadStream(file.path);

  const { optimize, isImage, isFaultyImage, isOptimizableImage } = strapi
    .plugin('upload')
    .service('image-manipulation');

  if (await isImage(currentFile)) {
    if (await isFaultyImage(currentFile)) {
      throw new ApplicationError('File is not a valid image');
    }
    if (await isOptimizableImage(currentFile)) {
      return optimize(currentFile);
    }
  }
  return currentFile;
}

src/index.ts

import { enhanceAndValidateFile } from './extensions/upload/overrides';

export default {
  register({ strapi }) {
    /**
     * Overriding enhanceAndValidateFile function to validate available file extensions
     */
    strapi.plugin('upload').service('upload').enhanceAndValidateFile =
      enhanceAndValidateFile;
  },
};

With this configuration, I get an error `throw new ApplicationError('File is not a valid image') ' when trying to upload an image to the media library. ' Everything worked with the plugin's 4.24.1 version.