Mocking Variadic Functions

[stretchr]

Mocking Variadic Functions

[robdaemon]

I've been looking at this - the issue happens around here: https://github.com/stretchr/testify/blob/master/assert/assertions.go#L40

Specifically, you end up with an expected of: []interface {}(nil) and an actual of []interface {}{}

I'll look and see if I can figure out why, but my initial instinct is that this is a Go issue.

I did find a workaround, which seems particularly nasty:

mockRedis.On("Send", "MULTI", reflect.Zero(reflect.TypeOf([]interface{}{})).Interface()).Return(nil)

[mveytsman]

Thanks for looking into this @robdaemon, I hope you figure it out. And yeah, that's a nasty workaround :)

[vladimirvivien]

Any update on this possible variadic issue ?

[ernesto-jimenez]

@vladimirvivien I'll look into it.

In the mean time, if the actual value is not important, a posible workaround would be using AnythingOfType.

An example working around the fact that we cannot compare anonymous funcs: #159 (comment)

[ernesto-jimenez]

Everything seems to work OK.

I've added some tests in PR #175

@robdaemon, @robdaemon:

Here's the solution:

var expected []interface{}
mockRedis.On("Send", "MULTI", expected).Return(nil)

No need for the reflect workaround.

Do you have any other use cases failing? Otherwise we'll just close this issue

Best,
Ernesto

[ernesto-jimenez]

@mveytsman @robdaemon @vladimirvivien any comments? or can I close the issue? :)

[vladimirvivien]

@ernesto-jimenez please close, I got around using the Any type in my assertion. Thanks for looking into this.

[ernesto-jimenez]

closing, thanks!