Comments (2)
@RemiMattheyDoret This proposal looks good. However the existing type switch must be preserved (for speed) and the switch on reflect.Kind
must be added in the existing default case (like mentioned in the "Consideration" section).
Also: because this change will allow us to accept typed numbers in InDelta*
and InEpsilon*
, I think that we must enforce that if the type of the expected value has a non-anonymous type, the actual value must be exactly of that type. So changes in InDelta
and InExpsilon
are expected too:
if reflect.TypeOf(expected).PkgPath() != "" {
IsType(t, expected, actual)
}
Both changes must happen at the same time: if we introduce the toFloat change first, the type check applied later would be then a breaking change.
As this change extends the behavior it will have to happen on a minor (not patch) release.
from testify.
Test case: https://go.dev/play/p/lGe4Y-2aBfz
func Test(t *testing.T) {
type F64 float64
assert.InDelta(t, F64(1.0), F64(1.0), 0.1) // This should succeed
assert.InDelta(t, 1.0, F64(1.0), 0.1) // This should succeed
assert.InDelta(t, F64(1.0), F64(1.0), 0.1) // This should fail: not the expected type
assert.InEpsilon(t, F64(1.0), F64(1.0), 0.1) // This should succeed
assert.InEpsilon(t, 1.0, F64(1.0), 0.1) // This should succeed
assert.InEpsilon(t, F64(1.0), F64(1.0), 0.1) // This should fail: not the expected type
}
So far all tests fail with "Parameters must be numerical".
from testify.
Related Issues (20)
- mock: Call.NotBefore still expects calls removed with Call.Unset HOT 6
- unnecessary/incorrect log call in AssertExpectations HOT 2
- Data race when mock is called with refernce to same object as expectation HOT 1
- assert fails and expects to dereference a reference HOT 1
- Add GoLang 1.22 to CI Testing Matrix for Package Compatibility Verification HOT 2
- error while importing github.com/stretchr/testify/suite: read C:\Program Files\Go\src\math\huge_test.go: unexpected NUL in input HOT 1
- AnythingOfType is marked deprecated on pkgsite HOT 1
- .On().Return() doesn't enforce expectation for the returned value HOT 1
- v1.9.0 breaks float comparisons with EqualValues HOT 6
- mock: cleanup argument matching API HOT 7
- Integer overflow in time.Time comparison
- EqualExportedValues can compare two slices HOT 2
- Regexp accepts interface{} HOT 3
- Drop outdated/abandoned dependencies HOT 3
- Proposal: Must-like utility HOT 3
- Proposal: assert.NotElementsMatch() HOT 4
- assert: invalid memory address or nil pointer dereference for assert.Error on darwin/arm64
- mock: Diff is prone to data races
- call.Unset() panics when call := mockObj.On("Foo", mock.AnythingOfType("foo")) HOT 1
- Proposal: assert.NoFieldIsEmpty HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from testify.