Giter Site home page Giter Site logo

Comments (4)

tylerstillwater avatar tylerstillwater commented on May 22, 2024

We use the assert package to run tests in mock.go. This loop is stepping up the stack to find the location of the call that failed. We have to explicitly tell it to step past the assert, mock, and require directories because they are at the top of the stack. However, we want it to return the location of the failed line in mock_test.go, which is in the mock directory, so we explicitly tell it to look for that test file.

from testify.

hhkbp2 avatar hhkbp2 commented on May 22, 2024

Thanks for the explanation.

When using assert/mock/require to write helper function for testing, it's useful to print out the caller stack which starts from the TestXXX function(which invokes the helper function) up to the assert/mock/require fail line(inside the helper function). For example, assure this function f() is a helper function for code reusage in test file xxx_test.go:

51 func f(t *testing.T) {
52    assert.True(t, false)
53 }

and in the test function it is called like:

100 func TestExample(t *testing.T) {
101     f(t)
....
105     f(t)
106 }

It's good to print out the caller stack when it fails:

        Location:         xxx_test.go:105
                          xxx_test.go:52
        Error:            ...

So I make a fork of the repository and add it for assert. The modification is here:

https://github.com/hhkbp2/testify/commit/78ef339d277a2ad71b39b2f74312949260681a82

I'm not sure whether there is someone else who wants this feature. If it is welcome I could do a pull request to merge it back to the main repo.

from testify.

tylerstillwater avatar tylerstillwater commented on May 22, 2024

I see. So you've made it possible to print out more of the stack than just the top entry. I like that a lot. It also seems not to change existing behavior. Even better! Make a PR and we'll review the changes, then merge it.

from testify.

hhkbp2 avatar hhkbp2 commented on May 22, 2024

I'm glad that you like it. The PR is made.

from testify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.