README is not correct

[stripe-samples]

README is not correct

[cjavilla-stripe]

I'm not sure I follow the request. Do you mean update the package.json to use node server.js for the start command?

[lgs]

The README says to use npm start for Node, but if you do it you'll got this errors:

lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions/server/node$ npm start server

> [email protected] start
> yarn server "server"

sh: 1: yarn: not found
lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions/server/node$ npm start start

> [email protected] start
> yarn server "start"

sh: 1: yarn: not found
lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions/server/node$ npm start test

> [email protected] start
> yarn server "test"

sh: 1: yarn: not found

because your package.json has yarn and npm mixed up ... which is confusing:

...
  "scripts": {
    "server": "node server/node/server.js",
    "reactClient": "cd client/react && npm start",
    "startReact": "concurrently \"yarn reactClient\" \"yarn server\"",
    "startVanillajs": "yarn server",
    "start": "yarn server",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
...

You also have two different package.json (also slightly different) in two different path:

lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions$ diff ./package.json server/node/package.json
2c2
<   "name": "stripe-subscription-with-fixed-price",
---
>   "name": "subscriptions-with-fixed-prices",
7,8c7,8
<     "server": "node server/node/server.js",
<     "reactClient": "cd client/react && npm start",
---
>     "server": "node server.js",
>     "reactClient": "cd ../../client/react && npm start",
24a25,27
>   },
>   "devDependencies": {
>     "@fullhuman/postcss-purgecss": "^2.1.2"

[lgs]

I say, just use one or the other (and in one place only). In my case :

lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions/server/node$ cat ./package.json
{
  "name": "subscriptions-with-fixed-prices",
  "version": "1.0.0",
  "description": "A Stripe sample implementing cards for subscriptions with fixed prices.",
  "main": "server.js",
  "scripts": {
    "server": "node server.js",
    "reactClient": "cd ../../client/react && npm start",
    "startReact": "concurrently \"npm run reactClient\" \"npm run server\"",
    "startVanillajs": "npm run server",
    "start": "npm run server",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "stripe-demos",
  "license": "ISC",
  "dependencies": {
    "autoprefixer": "^9.7.6",
    "body-parser": "^1.19.0",
    "concurrently": "4.1.2",
    "cookie-parser": "^1.4.5",
    "dotenv": "^8.0.0",
    "express": "^4.17.1",
    "postcss-cli": "^7.1.1",
    "stripe": "^7.4.0"
  },
  "devDependencies": {
    "@fullhuman/postcss-purgecss": "^2.1.2"
  }
}


lsoave@basenode:~/STRIPE/subscription-use-cases/fixed-price-subscriptions/server/node$ npm start

> [email protected] start
> npm run server


> [email protected] server
> node server.js

Node server listening on port http://localhost:4242!

[lgs]

But now I get the subscription process hanging forever.
I opened an issue here #100

[cjavilla-stripe]

Removed the yarn dependencies and the postcss dependencies that aren't used anymore. Also added some error handling to the node example.