[BUG]: Types are very incorrect in the package now in 3.x

[mikecousins]

[BUG]: Types are very incorrect in the package now in 3.x

[fruchtose-stripe]

Please download version v3.0.5 for corrected type declarations. Additionally, this issue has been remediated fully by release v3.0.4, so I'm going to close this issue. Thank you all for your patience up to this point. Please open a new issue if you continue to see related issues.

[dairyisscary]

Please download version v3.0.5 for corrected type declarations. Additionally, this issue has been remediated fully by release v3.0.4, so I'm going to close this issue. Thank you all for your patience up to this point. Please open a new issue if you continue to see related issues.

looks great, thanks @fruchtose-stripe

[cbala-stripe]

We are actively investigating the best path forward for fixing this issue. In the meantime, we recommend usage of version 2.4.0, which is our last stable release. Thank you for your patience with this issue.

[yktoo]

Perhaps related to #545.

[maxwelly-stripe]

Thank you for bringing up this issue with our team. We have published a new release which should resolve the issues you were having. Please upgrade to v3.0.1 instead of v3.0.0. Let us know if you continue to encounter any issues!

[TheSeg]

Getting an error when working within VSCode:

Could not find a declaration file for module '@stripe/stripe-js'. '/node_modules/@stripe/stripe-js/dist/stripe.mjs' implicitly has an 'any' type.
  There are types at '/node_modules/@stripe/stripe-js/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@stripe/stripe-js' library may need to update its package.json or typings.ts(7016)

On StackOverflow I found this answer that may lead to the fix, which amounts to defining the types in each "exports" entry:
https://stackoverflow.com/a/77566206/3574250

[maxwelly-stripe]

@TheSeg are you on version v3.0.0 or v3.0.1 when encountering this error?

[TheSeg]

@TheSeg are you on version v3.0.0 or v3.0.1 when encountering this error?

v3.0.1. I apologize for not stating that in the post!

[mikecousins]

They're still not correct: https://publint.dev/@stripe/[email protected]

[mikecousins]

This is another useful linter to help: https://arethetypeswrong.github.io/?p=%40stripe%2Fstripe-js%403.0.1

[fruchtose-stripe]

Hi @TheSeg. Could you please share what version of Node.js you're using, as well as your moduleResolution setting from tsconfig.json?

[TheSeg]

Sorry for not following up! v3.0.2 is all good for me now.

To answer your question, these are the relevant settings:

    "moduleResolution": "bundler",
    "customConditions": [
      "browser",
    ],

[fruchtose-stripe]

@TheSeg Thank you. That's very helpful. I'm working on a new PR to fix this issue more thoroughly.

[mikecousins]

Yup, it's functioning correctly now. I have a PR to remove the deprecated field: #547. The other one you'll want to set is the type to module. Then it should pass lint fine.

[dairyisscary]

This might be somewhat orthongonal to the issue reported in this ticket but pure.d.ts and index.d.ts type defintions are now incompatible with one another (typescript version 5.3.3 and skipLibCheck is not turned on). I don't fully understand why dist/index.d.ts is also being checked here since I only have a single import for @stripe/stripe-js/pure, but I am also using @stripe/react-stripe-js so maybe its sneaking in that way.

node_modules/@stripe/stripe-js/pure/index.d.ts:12618:5 - error TS2717: Subsequent property declarations must have the same type.  Property 'Stripe' must be of type 'StripeConstructor | undefined', but here has type 'StripeConstructor | undefined'.

12618     Stripe?: StripeConstructor;
          ~~~~~~

  node_modules/@stripe/stripe-js/dist/index.d.ts:12622:5
    12622     Stripe?: StripeConstructor;
              ~~~~~~
    'Stripe' was also declared here.


Found 1 error in node_modules/@stripe/stripe-js/pure/index.d.ts:12618```

[fruchtose-stripe]

Hi @dairyisscary. Thank you for this bug report. I have merged #560 to address it.