'stream is not defined' when loaded as npm module

[acao]

'stream is not defined' when loaded as npm module

[beeman]

I encountered this issue when including this module in webback.

Since I wanted to play with this module I have create a quick-and-dirty patch that fixes the issue for me: beeman@4d4209a

It would be nice if webpack would be supported.

[ritch]

Somehow the stream variable is not available. A version of the module should be bundled as a global variable in live-set.js.

[acao]

It is! But I think the module wasn't loading properly as it was packaged in my runtime. I've moved away from using angular for this project but here is what was happening.

I was not using browserify or requirejs or a script tag, but basically require() in electron.js. It was somehow able to load the angular module but not the Stream module from the global scope in my particular configuration. I tried doing var stream = require('stream') in the contest so that it would be, but i don't think it was in the right order because your script could not find it at compile time. It could also have been the way that babel was loading modules - I think you need special configuration for it to work with AMD modules properly.

In the future if people have this issue with electron.js or nw.js, I would suggest that they use jspm + system.js

[ritch]

Hmm - ya we should probably support browserify style module loading a bit better. In that case, there is no reason to shim the stream module at all... I wonder if the package.json should just point to a slim wrapper around that requires live-set.js. Something like:

// require-shim.js
module.exports = function(stream) {
  // contents of live-set.js
};

// main / index.js
require('./require-shim.js')(require('stream'));

[dhmlau]

Closing due to inactivity.