Inject `app` object to middleware factories

[strongloop]

Inject `app` object to middleware factories

[bajtos]

@raymondfeng I'd like to discuss this before we go and implement the injection. The canonical express way of accessing the app object is to use req.app from within the handler function. We are already doing this in loopback.rest().

What is so special about your middleware that it needs the app object outside of the handler function?

[bajtos]

Looking at oauth2-loopback.js, the component needs the app object for two tasks:

1. Register middleware prerequisites

  var session = (options.session !== false);

  app.middleware('auth:before', passport.initialize());
  if (session) {
    app.middleware('auth', passport.session());
  }

2. Setup models

var models = modelBuilder(app, options);

Further inspection of models/index reveals following usage:

• get hold of loopback to call loopback.getModelByType to auto-detect User and Application models to use
• resolve dataSource from a name via app.dataSources[name]

I would prefer to improve the middleware-registration process to support all three cases listed above instead of injecting the app object.

[bajtos]

On the second thought, middleware factory should not setup models nor register other middleware. Instead, we should implement a new mechanism to support complex components like oauth2.

The component exports function(app, options), end-user configures components in a new file (component-config.json?) and loopback-boot will invoke the functions exported by configured components.

This is most likely the item/feature that should have been implemented as part of #45.