Giter Site home page Giter Site logo

Point/Position naming about kolasu HOT 7 CLOSED

strumenta avatar strumenta commented on May 24, 2024
Point/Position naming

from kolasu.

Comments (7)

ftomassetti avatar ftomassetti commented on May 24, 2024 2

Ok, then I think we converge on renaming Position to Range in Kolasu 1.6.
Regarding renaming Point to Position I agree it could make things confusing.
Would it make sense to keep Point so that we would have a Range being composed by two Points?
This would go in branch 1.6

from kolasu.

alessiostalla avatar alessiostalla commented on May 24, 2024 1

Monaco/VSCode uses "range" for what we call Position. I wouldn't mind renaming Position to Range (and maybe Point to Position, though that could make migrating a bit confusing)

from kolasu.

ftomassetti avatar ftomassetti commented on May 24, 2024

Another thing to consider, related to this is #27
We should do this refactoring and understand if the name of the source (typically a source file) should go in "Point" -> "Position" or "Position" -> "Range"

from kolasu.

ftomassetti avatar ftomassetti commented on May 24, 2024

@mctaverna @alessiostalla @loradd do you have an opinion on the naming of these elements?

from kolasu.

mctaverna avatar mctaverna commented on May 24, 2024

@ftomassetti I don't really have an opinion, I remember that in GraalVM they have SourceSection.

from kolasu.

loradd avatar loradd commented on May 24, 2024

Ok, then I think we converge on renaming Position to Range in Kolasu 1.6. Regarding renaming Point to Position I agree it could make things confusing. Would it make sense to keep Point so that we would have a Range being composed by two Points? This would go in branch 1.6

Yes, I think that renaming Position to Range would be enough not to create too much confusion while achieving our goal.

from kolasu.

ftomassetti avatar ftomassetti commented on May 24, 2024

In branch future/16 we completed the renaming

from kolasu.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.