Comments (18)
There is now a security issue on latest working version of image sharp (2.1.6):
GHSA-65x7-c272-7g7r
Edit:
In the mean time, there is a fixed 2.1.7 version available from ImageSharp: https://github.com/SixLabors/ImageSharp/releases/tag/v2.1.7
from pdfsharpcore.
@ststeiger Can you please comment on all these requests on updating for ImageSharp. This is becoming an issue.
from pdfsharpcore.
Hi @ststeiger -
I just created this PR:
https://github.com/ststeiger/PdfSharpCore/compare/master...TonyValenti:PdfSharpCore:master?expand=1
Which upgrades various packages, including ImageSharp, to their latest stable, secure versions.
from pdfsharpcore.
Is there any news on this subject ? We are using this great library but this issue starts to be a big pain on our side :(
Thanks !
from pdfsharpcore.
@dejanmauer - lots of folks are running into this issue. I am really hopeful that @ststeiger will enable us to use the latest version of ImageSharp easily.
I've created this branch:
https://github.com/TonyValenti/PdfSharpCore
That enables the latest version of ImageSharp for modern .NET versions and uses the older version for legacy .NET versions.
Here's to hoping @ststeiger incorporates it!
from pdfsharpcore.
Later today I'll be submitting a PR that contains everything necessary to resolve this security issue.
from pdfsharpcore.
Will it include being able to use v3 of ImageSharp. And the bigger question, will @ststeiger respond and approve the PR.
from pdfsharpcore.
Yes. V3 for modern .NET and V2 for framework.
We'll have to wait and see if the maintainer of this package accepts it.
from pdfsharpcore.
@johnwc - my PR is here if you want to take a look.
from pdfsharpcore.
What are the main differences between the two versions of ImageSharpImageSource
? The two look almost exactly the same, minus a few method call differences. If that is the case, wouldn't it be better to just make the compile time directives within the few minor differences, rather than duplicate the code for each? I think it would be easier to maintain that way.
from pdfsharpcore.
@johnwc -
Here is a screen shot showing the compare:
In my experience, when you're dealing with subtle variances like this, you can easily get yourself in trouble by having a single file where you #if
things in and out. It is much safer and easier to maintain to branch the file.
from pdfsharpcore.
It would be better to maintain one file with a few compile time directives, than two files with almost same code. Think of someone else coming in and only changing one file for a security flaw. If it was in the same file, it would be seen and updated at the same time. Also, visual studio makes it very clear on what directive is currently being worked on and debugged with its coloring of the enabled directive. In my 25 years of development, I have never come across an issue of compile time directives being in a file in relation to this version vs that version compiling. The directives make it very clear what is going on.
from pdfsharpcore.
That's not a big deal to me either way as long as we can get the maintainer to merge and publish an update.
from pdfsharpcore.
Bump. :)
from pdfsharpcore.
same problem here ;(
from pdfsharpcore.
from pdfsharpcore.
+1
from pdfsharpcore.
Related Issues (20)
- Merge improvements from upstream PDFsharp
- Paragraphs added to HeaderFooter footer sections are written to the same position (and thus overlap)
- Manipulation with Gfx crops PDF page HOT 1
- Watermark Stream with negative height
- System.ArgumentException is thrown when creating XFont object with a custom font resolver
- Pdf Document Metadata and Properties are incorrect when adding UserPassword or OwnerPassword
- a release in .NET 7+ HOT 1
- Does it support adding electronic seals in PDf?
- 🛑 Still alive? HOT 3
- pdfsharpcore file size grows thrice after edit and save for header and footer
- pdfsharpcore is missing NuGet package README file
- Does not extract images from PDF HOT 4
- Base package without ImageSharp
- Non ascii characters are not correctly displayed when created on Linux (Openshift)
- Exception thrown when setting trailer info element to null HOT 4
- Visual Studio detecting Venerability with SixLabours.ImageSharp dependencies HOT 6
- Cannot insert image. HOT 10
- Can we take latest SixLabors / ImageSharp version which is v3.1.4 HOT 1
- Add Attachment to PDF-File (.xml File)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pdfsharpcore.