Option Chain: Some tickers fail

[studerw]

Option Chain: Some tickers fail

[higgsja]

I went out to the developer.tdameritrade.com site, tried a couple tickers including DIS with no issue at all. Remain scratching my head.

[higgsja]

Turns out GE and RUN cause the same issue.

[studerw]

Let me test with unit tests for DIS, GE, and RUN. They may have added a new enumeration type that will be easy to add.

[higgsja]

Excellent. Sounds right that maybe they have some with STOCK and some with EQUITY or something like that. a

…

-- Thanks! West Point 1976 H-3 Join us! <https://hlh-tx.com> *Mission:* To measurably improve investor performance "We enjoy the comfort of opinion without the discomfort of thought." -- J.F. Kennedy

On 1/6/21 2:52 PM, William Studer wrote: Let me test with unit tests for DIS, GE, and RUN. They may have added a new enumeration type that will be easy to add. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZKGI5MTT7GFMNGWM4CE4TSYTER7ANCNFSM4VX2DYDA>.

[higgsja]

Add CVX to the list ...

[higgsja]

Ok, may be as simple as changing the following in OptionDeliverable.java (or not as I messed with a lot of things beyond my understanding).

change:
public enum AssetType { CASH_EQUIVALENT, CURRENCY, EQUITY, FIXED_INCOME, INDEX, MUTUAL_FUND, OPTION }

to:
`public enum AssetType {
CASH_EQUIVALENT,
CURRENCY,
EQUITY,
FIXED_INCOME,
INDEX,
MUTUAL_FUND,
OPTION,
STOCK
}'

[studerw]

Yes I think that might just be enough to fix it. If you want to test it out, checkout the master branch and make your fix to the OptionDeliverable.AssetType enum in master branch.

Then, run a maven clean install. You'll see that you now installed the api with version 2.4.0-SNAPSHOT into your local Maven repository. Then in your actual app, change the version from whatever you were using (2.3.0) to 2.4.0-SNAPSHOT. Then rebuild your app and try to run the same query that was giving you problems.

Let me know if it works. If so, you could either add a Pull Request with the change (so you can get the Github Cred!!) or I can just do it manually. I think your other error in issue #36 might be as easy to fix. It is just the TDA keeps changing their API for no good reason and breaking code that depends on it :(

[studerw]

@higgsja Thanks for your help on this. I just looked on TDA's dev site and apparently they don't have any Enumeration for AssetType nor Currency Type (previously it was USD, CAD, JPY, EUR). Instead their Json Schema just lists them as Strings, so I'm going to do the same and convert them to string. Merged into Master which is 2.4.0-SNAPSHOT. I'll make a full 2.4.0 release later this week with other issues. Thanks Again!