JSZip with Blob unexpected behaviour

[stuk]

JSZip with Blob unexpected behaviour

[dduponchel]

Good idea. If JSZip can use the File API (when reading or writing), it will be easier and more straightforward to use in some use cases.
I have started working on it.

[dduponchel]

This is on my branch issue23. This should solve the stackoverflow issue with a

sendFile("x.zip", zip.generate({responseType:"blob"}));

I still need to be sure I didn't break older browsers (I will be able to test IE 6-9 the next week).
@Stuk : could you check the updated documentation ? I would like to be sure you're ok with the responseType parameter and the new examples.

[Stuk]

The extra option looks good, but I think just type would be a better name, as there is no response :)

Do you think it would be a good idea to deprecate the base64 option in lieu of type: "base64" to keep things simple?

Finally, could you add the other possible values (uint8array, arraybuffer ) to the jsdoc?

[dduponchel]

You're right, type is better. I spent to much time playing with the ajax's responseType :)

I think that deprecating base64 is a good idea : generate({type:"string"}) doesn't clearly show what the output will be (but will confuse the reader) and generate({type:"arraybuffer", base64:true}) doesn't make any sense.

My branch issue23 should be ready this week-end !

[dduponchel]

JSZip now generates Blobs / ArrayBuffers / Uint8Array, check the documentation. Thanks for the bug report :)

[pbhd]

Good job!, I consider JSZip a very usefu piece of code. Keep going...

Cheers, Peter  

Von: David Duponchel <[email protected]> 

An: Stuk/jszip <[email protected]> 

Cc: pbhd <[email protected]> 

Betreff: Re: [jszip] JSZip with Blob unexpected behaviour (#23) 

Datum: Tue, 22 Jan 2013 21:40:00 +0100 

JSZip now generates Blobs / ArrayBuffers / Uint8Array, check the

documentation [1]. Thanks for the bug report :)

—

Reply to this email directly or view it on GitHub [2].

Links:

[1] http://stuk.github.com/jszip/#doc_generate_options
[2] #23 (comment)