Comments (13)
I will give it a shot this weekend.
from stumpwm-contrib.
Maybe you should have a look at this: stumpwm/stumpwm#454, @lepisma.
from stumpwm-contrib.
I'm not the author of this module, but maybe this was intended? Although looking at the screenshot of the module, maybe not.
Perhaps there should be an option whether a user wants to apply gaps to the modeline or not. Thoughts?
from stumpwm-contrib.
I am the author (for the outer gaps thing). I used polybar so didn't face this issue. I agree about having an option for applying gaps to modeline.
I think it might need some refactoring since the outer gaps were implemented by resizing the whole head. Allowing modeline might mean changing this.
from stumpwm-contrib.
Another way might be to make the modeline aware of gaps and have it position itself correctly. Though I am not sure which way is going to be easier/better. Thoughts?
from stumpwm-contrib.
Thanks for the replies. My Lisp skills are poor so I don't know how easy it would be to implement the features. My guess is not very easy
Having the option to apply gaps to the modeline or turning it off would be cool though.
Applying gaps to the modeline could be another module maybe with separate code? I'm not sure if that would work either.
from stumpwm-contrib.
I have a possible fix in here. There are now three kind of gaps defined by the following variables:
*head-gaps-size*
. This is what borders the monitor. Everything (including modeline) comes inside its boundary. You would want to set it to 0.*outer-gaps-size*
mimicks the behaviour of the older variable with same name but adds asymmetric gaps around individual windows after checking if they are facing monitor edges.*inner-gaps-size*
is the same old thing.
Here is a quick picture to describe these.
The outermost gaps are due to *head-gaps-size*
. The innermost (around all edges of window) are due to *inner-gaps-size*
and the extra gaps for the monitor facing edges is from *outer-gaps-size*
.
Try the fork and see if it behaves correctly. If all looks fine, then I will create a PR here.
from stumpwm-contrib.
Thanks Abhinav it seems to work fine. I am getting an error message though which doesn't effect the functionality though. It only appears when the gaps are toggled on.
Error in Command 'toggle-gaps': The function STUMPWM:ONLY-TILE-WINDOWS is undefined.
Maybe I am doing something wrong?
from stumpwm-contrib.
I just tried it myself. Seems to work fine. @lepisma
How are you getting that error? @jamesmccabe (I tried the same config with the binding as you and get no error)
from stumpwm-contrib.
Which version of stumpwm are you using @jamesmccabe? (although the missing function is around a year old so don't know if this matters).
from stumpwm-contrib.
Sorry I am using stumpwm version 1.0.0 so I think this is the problem. I will test the git version later.
from stumpwm-contrib.
Right, I now realize that v1 doesn't have that fn. Since, v1 is latest stable release, should I revert the change that I made (lepisma@08918d7)? I think addon modules should at least work with the latest stable.
from stumpwm-contrib.
Or I can also take this opportunity to ask @dbjergaard if v1.0.1-rc
can go as a stable release? I feel there are sufficient amount of really useful changes in the rc
. Its also been working without any hiccups for me at least. How are others feeling about it?
from stumpwm-contrib.
Related Issues (20)
- Long notifications crash stumpwm HOT 1
- Battery-portable does not work with certain sysfs battery directories
- Suggestion: add tests to stumpwm-contrib using FiveAM or otherwise HOT 1
- swm-gaps can crash stumpwm with negative size windows HOT 6
- [winner-mode] Winner mode seems broken on stumpwm master HOT 1
- stumptray can't load in my environment HOT 1
- ttf-fonts can't be loaded due to broken dependency. HOT 2
- swm-gaps crashes with _NET_FRAME_EXTENTS negative value HOT 7
- Stumptray issues - icons visibility and desappearance HOT 1
- CPU - modeline/cpu display '%c' instead of it's value HOT 2
- Variable for module titles in modeline? HOT 2
- stumpwm-backlight breaks with clx-20200715-git with "odd number of &KEY arguments" HOT 1
- Document simple example usage sequence
- winner-mode shows message "Group dumped" on every window switch. HOT 1
- Productivity module issues leading to extreme unproductivity HOT 4
- module variables not getting set HOT 6
- stumpwm-dmenu stops loading with error (xEMBED) HOT 1
- cpu module broken by a commit HOT 1
- mem-modeline-fmt should be external HOT 2
- clim-modeline: redisp fails with error.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stumpwm-contrib.