Doesn't run after install

[RussMax783]

Doesn't run after install

[stutrek]

Thanks @RussMax783 and @zacanger, the new version is pure babel and I took your minimal breaking case and added it to the repo as a simple test.

You can make scroll containers now too, so you'll have to import { Watch } from 'scrollmonitor-react'. Version bump to 2.0 too, since it's a breaking change.

Thanks again for your help.

[zacanger]

Minimal example: https://github.com/zacanger/scrollmonitor-react-issue-2

[stutrek]

Are you working on something small that I could clone and try out?

What version of Node are you on?

[RussMax783]

Node: v6.7.0

unfortunately its a pretty large project that i cant do that... But here is what i've found...

I copied your index.js file and put it into my own component and it worked. So im pretty sure it has something to do with your build.

putting "main": "dist/index.js" in your package.json will point to make sure everyone is using the build you have in dist.

Like i said above, when i am able to run dist/index.js i get scrollMonitor is not defined, and looking at index.js line 175, scrollMonitor is not defined anywhere. Maybe because you're marking scrollmonitor as an external? in webpack.config.js

[zacanger]

Removing the externals obj and running webpack builds as expected. Not sure what the intention is with those options, but unless I misunderstand externals, I think that would only work if React, ReactDOM, and scrollMonitor were exposed on window?

[stutrek]

That's it. The externals lets webpack build it without including the files, but that's not the solution I should have used.

[zacanger]

Thanks very much!