Giter Site home page Giter Site logo

Comments (12)

meh-uk avatar meh-uk commented on July 2, 2024

From my perspective that sounds like an awesome project.

from stylecop.

sharwell avatar sharwell commented on July 2, 2024

@meh-uk It's been remarkably successful on basically every front. Some of the contributors are obsessed with ensuring the code fixes are highly accurate in the most bizarre code, while others are keeping a close watch on StyleCop "classic" to make sure we only deviate from its behavior in places where the original had problems.

from stylecop.

meh-uk avatar meh-uk commented on July 2, 2024

Is it correct that individual rules are only configurable in Visual Studio 2015? Ah I see it is Visual Studio 2015 only - still awesome though :).

from stylecop.

sharwell avatar sharwell commented on July 2, 2024

Is it correct that individual rules are only configurable in Visual Studio 2015?

The project is built entirely on the new compiler, so you'll need to compile with Visual Studio 2015 to use it. The warnings it produces (or errors if you customize the severity) are reported in the build itself and not as a separate pass, which means errors will prevent the compiler from creating an output assembly.

Note that you can still install the StyleCop.Analyzers NuGet package in a project where some developers use Visual Studio 2013 or earlier, but it simply won't report results during the build and you won't have access to code fixes in the IDE. That said, you really should try to update to 2015; it's a tremendous improvement all-around.

from stylecop.

citizenmatt avatar citizenmatt commented on July 2, 2024

Yep, agreed on all points so far - StyleCop users are an obsessive bunch πŸ˜„

Very nice looking project, and love the status page! My main concern is ReSharper users, mostly those not on VS2015. But I don't like the duplication of effort, and personally, I'd rather not maintain StyleCop as I don't use it. And yet we still have plenty of users not using VS2015 that want StyleCop.

Short term, getting a new ReSharper plugin for StyleCop is easily achieved without causing any harm to any of the projects. Longer term, I don't really know what's for the best.

But you can always come under the StyleCop organisation πŸ˜›

from stylecop.

sharwell avatar sharwell commented on July 2, 2024

@citizenmatt I understand. Perhaps a solution is the following:

  1. Update this code base to support newer versions of ReSharper, and that's all. No new rules, and no need to support C# 6 (though it would still work in Visual Studio 2015 with C# 5).
  2. For users that want support for C# 6 (which implies Visual Studio 2015), direct them to the project we are working on.

This reduces your workload dramatically (by not having to consider any new style rules), eliminates the duplication of effort, and gives a strong long-term direction to automated style checking and correction.

from stylecop.

meh-uk avatar meh-uk commented on July 2, 2024

Sounds good.

from stylecop.

citizenmatt avatar citizenmatt commented on July 2, 2024

Yeah, this sounds like a good solution to me, too. My primary focus is getting ReSharper support up and running. So, in the short term, I have no plans to release a new version of StyleCop, add new rules, or whatever. I can potentially see me back porting some of your new rules to the ReSharper plugin, but that's as far as I would go (although if anyone turns up with PRs for StyleCop itself, it'll be time for another discussion…)

And I'll add info to the readme to point to the DotNetAnalyzers/StyleCopAnalyzers repo and gitter room.

from stylecop.

markvantilburg avatar markvantilburg commented on July 2, 2024

When using this with resharper 9.2 (on vs2015) there should also be some instructions how to configure it...

from stylecop.

citizenmatt avatar citizenmatt commented on July 2, 2024

Good point. A VS2015 version of the ReSharper plugin should be about setting your config correctly.

from stylecop.

markvantilburg avatar markvantilburg commented on July 2, 2024

Not sure if you misread, but out of the box there is a conflict between StyleCopAnalyzers and resharper.

See DotNetAnalyzers/StyleCopAnalyzers#1346

from stylecop.

citizenmatt avatar citizenmatt commented on July 2, 2024

No, didn't misread. I'm saying that the plugin, under VS2015 would automatically configure ReSharper to be StyleCop compliant, but leave the analysis to StyleCopAnalyzers.

from stylecop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.