Comments (3)
Can we close this 🙈
from simple-peer-files.
Umm he did ask me if he could do it and I let him 😂
So yeah. It's cool.
P.S. The reason I didn't put up any licenses is because I don't really care about people using my code. It was just a fun experiment and that's pretty much it. If people can find use with it for actual serious efforts, then so be it ^_^
from simple-peer-files.
Legally you are allowed to do this since justshare-client is not copyrighte
Nope. If there is no stated LICENSE on code/github, the copyright remain solely with the author and need explicit permission for using that code. Just because there's no LICENSE mentioned doesn't mean the code in GitHub is public-domain. I did ask Andrew before making this library.
Most of the code is copied/ modified
Let me give some context here. I was trying to find an alternative to WebTorrent in sending files in WebDrop. Sending files over WebTorrent is performance-heavy. IIRC, Andrew sent me his project saying that he has also made a P2P file share. So I checked that out and found the chunked file sending. I asked his permission and used his code in the initial implementation. But then, that implementation didn't work well. So I did a MASSIVE rewrite and added many more stuff. So it's incorrect to say "most of the code is copied". His project did help me to make simple-peer-files
. What differentiates this from that mainly is that there's very little dependencies and can be used in many places. I could've erased the previous git-history after the rewrite, but I didn't. So the credit to Andew is still in the git history. Okay, I'll add it to the README too.
issue a non-MIT license
I care about changes to this library be also FOSS so that it helps other beneficiaries of this library. Hence Mozilla Public License.
@AndrewBastin I'd recommend you and others use MPL or GPL because if the changes/derivative works are also FOSS, it'll help your project and other users too. MIT is too permissive, and sometimes some good changes will never be made into a PR, kept hidden in some commercial app and doesn't benefit the community :(
from simple-peer-files.
Related Issues (8)
- ArrayBuffer is stored in memory? HOT 2
- window.requestFileSystem HOT 2
- Uncaught TypeError: Cannot read property 'cancel' of null HOT 2
- Cannot use namespace 'Peer' as a type. HOT 1
- How to send files?
- Failed to execute 'readAsArrayBuffer' on 'FileReader': parameter 1 is not of type 'Blob'. HOT 1
- Bump simple-peer dependancy as Chromium 110 introduced some WebRTC changes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-peer-files.