Comments (7)
Of course, because the view is not called first, but always after model changes.
willUnmount is only called before the UI component is disposed.
What do you try to solve?
from substance.
Yeah i understand but no idea how to solve it properly. A guard in the willUnmount seems not a sane way?
from substance.
but what are you trying to do with document in willUnmount?
from substance.
Unregister the event proxies...
https://github.com/substance/substance/blob/master/ui/nodes/link_component.js#L26-L27
from substance.
Store doc in this.doc during didMount. That's ok to do.
from substance.
ok
from substance.
Fixed.
from substance.
Related Issues (20)
- Found a case where XMLDocumentNode.find() does not find a direct child HOT 1
- [question] The best practice for loading an asynchronous document into an editor
- Asciidoc backend? HOT 1
- A selection should not be allowed to point to a non existing surface HOT 1
- Edit inline node is not working for nodes which goes one after another HOT 4
- Why does substance depend on substance? HOT 2
- [Feature Request] Allow substance components to return components as their root? HOT 12
- ES5 support? HOT 4
- Allow to insert before first node if it is an isolated node. HOT 11
- Plans to an import-HTML module?
- Error in "isDisabled" function in InsertInlineNodeCommand class
- Importing references without doi HOT 1
- CDATA Text elements makes schema invalid HOT 1
- DOM.parseSnippet() provides two elements when content is CDATA
- Clicking on InlineNode inside of IsolatedNode selects the IsolatedNode HOT 1
- Strange DOM selection after click
- Draggable InlineNodes have a strange selection in Chrome HOT 1
- JS-YAML Error HOT 1
- npm start does not work as described in README.md HOT 2
- Is substance.io died? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from substance.