Comments (10)
Does component.unmount() not work?
from substance.
Just found it. I want to test deregistration of event handlers.
from substance.
Which seems not to be done in that case. In _updateElement there's the only place:
if (!_.isEqual(oldData.handlers, data.handlers)) {
_.each(oldData.handlers, function(handler, event) {
$el.off(event);
});
_.each(data.handlers, function(handler, event) {
$el.on(event, handler.bind(scope.owner));
}, this);
}
from substance.
Well, this seems to be a bug.
from substance.
On a second thought: I don't think it is necessary to unbind the event handlers. They are part of the rendered element. It should not matter if they are still there after unmount. I would leave them.
from substance.
But wouldn't this prevent the component from being garbage collected if there's a handler from that component bound to the element that could potentially survive... I'm not sure i understand this completely. I mean why it does not matter to not call .off().
from substance.
No. Why would it. Both, the component and the element are having the same life-time.
from substance.
Why should the element survive?
from substance.
Mhh.. probably true yes.. and if i keep a reference to the unmounted component or el, it's the user's fault.
from substance.
I think so.
from substance.
Related Issues (20)
- Found a case where XMLDocumentNode.find() does not find a direct child HOT 1
- [question] The best practice for loading an asynchronous document into an editor
- Asciidoc backend? HOT 1
- A selection should not be allowed to point to a non existing surface HOT 1
- Edit inline node is not working for nodes which goes one after another HOT 4
- Why does substance depend on substance? HOT 2
- [Feature Request] Allow substance components to return components as their root? HOT 12
- ES5 support? HOT 4
- Allow to insert before first node if it is an isolated node. HOT 11
- Plans to an import-HTML module?
- Error in "isDisabled" function in InsertInlineNodeCommand class
- Importing references without doi HOT 1
- CDATA Text elements makes schema invalid HOT 1
- DOM.parseSnippet() provides two elements when content is CDATA
- Clicking on InlineNode inside of IsolatedNode selects the IsolatedNode HOT 1
- Strange DOM selection after click
- Draggable InlineNodes have a strange selection in Chrome HOT 1
- JS-YAML Error HOT 1
- npm start does not work as described in README.md HOT 2
- Is substance.io died? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from substance.